Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upupdate mutate.tbl_tree() to not assume dplyr:::mutate.tbl_df() exists #12
Conversation
Closed
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The current implementation of
mutate.tbl_tree()uses an internal method from dplyr, i.e.dplyr:::mutate.tbl_df()which won't be present indplyr1.0.0IIUC, this was about just adding the
tbl_treeclass to the result of callingmutate(), here is a proposed implementation.Please consider this fix, as currently this breaks packages: genBaRcode, ggtree, LymphoSeq, nosoi, philr, tidytree, treeio, TreeSummarizedExperiment, universalmotif