Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinAPI does not implement extensions #185

Closed
glyph opened this issue Apr 11, 2023 · 5 comments
Closed

WinAPI does not implement extensions #185

glyph opened this issue Apr 11, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@glyph
Copy link

glyph commented Apr 11, 2023

For example, microsoft defines WEBAUTHN_EXTENSIONS_IDENTIFIER_HMAC_SECRET here:

https://github.com/microsoft/webauthn/blob/9fb38aa2775e286f504fc087efc62e5557bee881/webauthn.h#L386

but it is not exposed via python-fido2

@dainnilsson
Copy link
Member

dainnilsson commented Apr 17, 2023

Yes, the WinAPI implementation currently does not support any extensions. This would be a nice addition to the library, but I do now not know when we'll be able to implement it.

@dainnilsson dainnilsson added the enhancement New feature or request label Apr 17, 2023
@glyph
Copy link
Author

glyph commented May 3, 2023

@dainnilsson presumably you mean "do not know"?

@dainnilsson
Copy link
Member

@dainnilsson presumably you mean "do not know"?

Yes, thanks for catching that! 😄

@dainnilsson
Copy link
Member

Version 1.2 has now been released, with support for extensions in the WinAPI client.

@glyph
Copy link
Author

glyph commented Dec 4, 2024

@dainnilsson For my use-case, this presents some weird UI. It seems to work, but it implies that it's going to make a resident key every time I do an HMAC secret. Is this worth reporting a bug about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants