New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep session in examples #10

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@prprhyt

prprhyt commented Jul 14, 2018

I fixed #9.

@dainnilsson

This comment has been minimized.

Member

dainnilsson commented Jul 23, 2018

I don't see why credentials: 'include' should be needed here. All requests should be same-origin, which is the default:

From https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch

By default, fetch won't send or receive any cookies from the server, resulting in unauthenticated requests if the site relies on maintaining a user session (to send cookies, the credentials init option must be set).
Since Aug 25, 2017. The spec changed the default credentials policy to same-origin. Firefox changed since 61.0b13.

What browser and which version are you using?

@dainnilsson

This comment has been minimized.

Member

dainnilsson commented Aug 7, 2018

Closing, see #9.

@dainnilsson dainnilsson closed this Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment