Join GitHub today
Updated C# code #1
I made a few changes to your .NET client to make it follow the .NET conventions a little better (getters & setters). I also fixed a few bugs. Your exception classes weren't calling the base constructor, so the parameters passed in the constructor were not being set anywhere. Also, you weren't disposing a few of the crypto and I/O classes.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Thanks for your interest and improvements.
To make this easier for us to merge, do you think you could split it up in functional parts that can be reviewed and discussed sepparately?
To be able to merge this, I will need confirmation in writing (e-mail is fine) that you agree to contribute it under the copyright of the yubico-dotnet-client project (basically a 2-clause BSD license, but see the file COPYING). If you send me a short e-mail to firstname.lastname@example.org stating this is your intention that will be enough.