Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp to logs, and log only to backup_borg.err #55

Merged
merged 1 commit into from
Nov 11, 2020
Merged

Add timestamp to logs, and log only to backup_borg.err #55

merged 1 commit into from
Nov 11, 2020

Conversation

eauchat
Copy link
Contributor

@eauchat eauchat commented Oct 6, 2020

A possible solution to the two remarks in #26.
The 2>&1 >/dev/null syntax allows to redirect stderr to stdout and therefore being able to pipe it and add timestamps before appending to log file. Logging stderr only should be enough since stdout is not used by the borg command.

Copy link
Contributor

@zamentur zamentur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@alexAubin alexAubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super quick review, LGTM ?

@zamentur zamentur merged commit 30b7340 into YunoHost-Apps:testing Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants