Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ini file for php #42

Merged
merged 1 commit into from Nov 8, 2018
Merged

Remove ini file for php #42

merged 1 commit into from Nov 8, 2018

Conversation

maniackcrudelis
Copy link

@maniackcrudelis maniackcrudelis commented Oct 1, 2018 •
edited by frju365

Problem

Solution

  • Get rid of the ini file and merge its content into the pool file.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Josué
  • Approval (LGTM) : Josué
  • Approval (LGTM) : frju365
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team October 1, 2018 22:35
@frju365
Copy link
Member

frju365 commented Nov 2, 2018

Will be merge in 3 days !

@frju365 frju365 merged commit af62ef0 into testing Nov 8, 2018
@maniackcrudelis maniackcrudelis deleted the remove_php_ini branch May 24, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josue-T Josue-T Josue-T approved these changes

@frju365 frju365 frju365 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maniackcrudelis @frju365 @Josue-T