Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new permission system introduced in YnH v3.7/v4.1: BMA not accessible, Admin accessible to visitors #89

Closed
M5oul opened this issue Oct 1, 2020 · 7 comments
Closed

Handle new permission system introduced in YnH v3.7/v4.1: BMA not accessible, Admin accessible to visitors #89

M5oul opened this issue Oct 1, 2020 · 7 comments
Assignees
@M5oul
Labels
bug
Milestone
0.5

Comments

@M5oul
Copy link
Member

M5oul commented Oct 1, 2020 •
edited

Reported twice

New permission system
@M5oul M5oul added the bug label Oct 1, 2020
@M5oul M5oul added this to the 0.5 milestone Oct 1, 2020
@M5oul M5oul self-assigned this Oct 2, 2020
M5oul added a commit that referenced this issue Oct 2, 2020
@M5oul
[fix] #89: Use new permission system
39f75cd 
Use ynh_permission_* helpers
Keeping BMA accessible to visitors
and Duniter admin interface accessible to the selected admin
Remove deprecated permission system settings
@M5oul M5oul closed this as completed Oct 2, 2020
M5oul added a commit that referenced this issue Oct 3, 2020
@M5oul
Revert "[fix] #89: Use new permission system"
843e745 
This reverts commit 39f75cd.
The permission system is not fully ready yet, since we can not protect
two paths
M5oul added a commit that referenced this issue Oct 3, 2020
@M5oul
[fix] #89: Remove /modules path from allowed path to visitors
b674b9a 
since it brokes the access BMA since YnH v3.7 permission system
@M5oul M5oul reopened this Oct 3, 2020
@M5oul
Copy link
Member Author

M5oul commented Oct 3, 2020 •
edited

I fixed the issue of this ticket. I let it open to support the new permission system.
The new permission system is not supporting the protection for two paths for an admin user.
This support have to be added in ynh_permission_create helper to proceed.

@Thatoo
Copy link
Contributor

Thatoo commented Mar 3, 2021

Will be following this issue closely :-)

M5oul added a commit that referenced this issue Mar 28, 2021
@M5oul
[fix] #89: Disable web admin since it is no longer protected
aacb279 
with the new permission system brought by YunoHost v4.1
@M5oul M5oul changed the title BMA not accessible as a visitor since YunoHost v3.7 introduced a new permission system Handle new permission system introduced in YnH v3.7/v4.1: BMA not accessible, Admin accessible to visitors Mar 28, 2021
M5oul added a commit that referenced this issue Apr 1, 2021
@M5oul
[fix] #89: Disable web admin since it is no longer protected
693f356 
with the new permission system brought by YunoHost v4.1
M5oul added a commit that referenced this issue Apr 1, 2021
@M5oul
[fix] #89: Use new permission system:
1289409 
Requires YnH v4.1 which implements this new permission system
Use ynh_permission_create helper
Set Duniter admin interface accessible to the selected admin
BMA is set as accessible to visitors by default
Remove / −> /webui redirection, since this change adds a tile to the admin
Remove deprecated permission system settings
Re-enable the web admin since it is protected again
Rename f() name
M5oul added a commit that referenced this issue Apr 1, 2021
@M5oul
[fix] #89: Use new permission system:
c20cbff 
Requires YnH v4.1 which implements this new permission system
Use ynh_permission_create helper
Set Duniter admin interface accessible to the selected admin
BMA is set as accessible to visitors by default
Remove / −> /webui redirection, since this change adds a tile to the admin
Remove deprecated permission system settings
Re-enable the web admin since it is protected again
Rename f() name
@duckwoqei
Copy link

There was a typo in the link provided, the correct one:

sudo yunohost app upgrade duniter -u https://github.com/YunoHost-Apps/duniter_ynh/tree/89_new_permission_system

@duckwoqei
Copy link

Get an error in upgrading, both as admin and root:

Info: WARNING - Permission 'duniter.admin' not found
Info: ERROR - Could not upgrade duniter: An error occurred inside the app upgrade script
Error: The operation 'Upgrade the 'duniter' app' could not be completed. Please share the full log of this operation using the command 'yunohost log display 20210404-220805-app_upgrade-duniter --share' to get help
root@sis:/home/admin# yunohost log display 20210404-220805-app_upgrade-duniter --share
Info: This log is now available via https://paste.yunohost.org/raw/ajajijaref

M5oul added a commit that referenced this issue Apr 13, 2021
@M5oul
[fix] #89: Use new permission system:
67e49bf 
Requires YnH v4.1 which implements this new permission system
Use ynh_permission_create helper
Set Duniter admin interface accessible to the selected admin
BMA is set as accessible to visitors by default
Remove / −> /webui redirection, since this change adds a tile to the admin
Remove deprecated permission system settings
Re-enable the web admin since it is protected again
Rename f() name
@Thatoo
Copy link
Contributor

Thatoo commented Apr 17, 2021

I have tried
sudo yunohost app upgrade duniter -u https://github.com/YunoHost-Apps/duniter_ynh/tree/89_new_permission_system
it says there is no such branch
and then I tried
sudo yunohost app upgrade duniter -u https://github.com/YunoHost-Apps/duniter_ynh/tree/master
because I saw you merged things in master but the update failed.
Here is the log : https://paste.yunohost.org/raw/pabudugisu

@Thatoo
Copy link
Contributor

Thatoo commented Apr 22, 2021

Today, I could update with
sudo yunohost app upgrade duniter -u https://github.com/YunoHost-Apps/duniter_ynh/tree/master
@M5oul : it seems like people can't reach https://g1.leprette.fr/webui anymore. However, I have two tiles in the yunohost interface, "duniter" and "duniter (adminstration)". Not a big issue, just to mention.

@M5oul
Copy link
Member Author

M5oul commented Mar 27, 2022

This issue got fixed before the refactoring. To be checked if the access to BMA for everyone and the web admin to the admin have been maintained.

@M5oul M5oul closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@M5oul M5oul

Labels
bug
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
3 participants
@Thatoo @M5oul @duckwoqei