Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #69

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@maniackcrudelis
Copy link
Collaborator

commented May 13, 2019

Problem

  • Global upgrade of the package.
  • Upgrade to Etherpad 1.7.5

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : kay0u
  • Approval (LGTM) : kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis added some commits Apr 15, 2019

Merge pull request #68 from YunoHost-Apps/package_upgrade
Normalization from example_ynh

@maniackcrudelis maniackcrudelis marked this pull request as ready for review May 20, 2019

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group May 20, 2019

@kay0u

This comment has been minimized.

Copy link
Member

commented May 21, 2019

I don't understand the problem with the CI.

@maniackcrudelis

This comment has been minimized.

Copy link
Collaborator Author

commented May 21, 2019

Don't know either, it's often failing on that part, but randomly...
Never found any reason for it.

I guess we can ignore it, since it's totally random.

@kay0u

kay0u approved these changes May 21, 2019

Copy link
Member

left a comment

LGTM & code review

@JimboJoe
Copy link
Contributor

left a comment

LGTM 👍

@JimboJoe

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Can be merged in 3 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.