Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update 0.18 #58

Merged
merged 7 commits into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@PierrickBrun
Copy link

PierrickBrun commented Jan 27, 2019

To address #56

For now, it installs itself but package_check gets 502 errors when trying to connect to the app.

@Jibec

This comment has been minimized.

Copy link
Collaborator

Jibec commented Jan 27, 2019

@EliotBerriot

This comment has been minimized.

Copy link
Collaborator

EliotBerriot commented Jan 28, 2019

For now, it installs itself but package_check gets 502 errors when trying to connect to the app.

It likely indicates that the funkwhale-server service is not running. If you want to share the logs for this process, I can have a look :)

@PierrickBrun

This comment has been minimized.

Copy link
Author

PierrickBrun commented Jan 28, 2019

Thanks for your help :)

@Jibec you mean in the development context ? I see this file already being referenced like that somewhere else. I will try, this is indeed better to see what I'm working with.

@EliotBerriot Yes, I remember having investigated it a bit and journalctl told me funkwhale-server was up. I'm a bit wondering if it was up soon enough for the test. What is the logfile that would help you, funkwhale/server.log ? I will send it once I can access my VM, I remember having seen a warning about some problems in the dependencies.

@PierrickBrun

This comment has been minimized.

Copy link
Author

PierrickBrun commented Jan 28, 2019

Okay nevermind, the /var/log/funkwhale/server.log is empty so I guess the requests weren't hitting it.

Here is the result of service funkwhale-server status:
Jan 28 18:03:22 pchecker_lxc systemd[1]: Started Funkwhale (funkwhale) application server.
Jan 28 18:03:24 pchecker_lxc funkwhale-server[9298]: 2019-01-28 18:03:24,795 INFO Loaded env file at /var/www/funkwhale/code/config/.env
Jan 28 18:03:26 pchecker_lxc funkwhale-server[9298]: 2019-01-28 18:03:26,654 INFO Starting server at tcp:port=5000:interface=127.0.0.1
Jan 28 18:03:26 pchecker_lxc funkwhale-server[9298]: 2019-01-28 18:03:26,665 INFO HTTP/2 support not enabled (install the http2 and tls Twisted extras)
Jan 28 18:03:26 pchecker_lxc funkwhale-server[9298]: 2019-01-28 18:03:26,665 INFO Configuring endpoint tcp:port=5000:interface=127.0.0.1
Jan 28 18:03:26 pchecker_lxc funkwhale-server[9298]: 2019-01-28 18:03:26,671 INFO Listening on TCP address 127.0.0.1:5000

I wonder if this Pillow version warning is causing trouble, any idea @EliotBerriot ?
http2 isn't activated in the nginx conf so this shouldn't come from this https://dev.funkwhale.audio/funkwhale/funkwhale/commit/635865ac82e2a3ff3641c22e45d95587b95bc149 .

@EliotBerriot

This comment has been minimized.

Copy link
Collaborator

EliotBerriot commented Jan 31, 2019

@PierrickBrun I don't see any Pillow warning in your logs, sorry (and the HTTP2 thing can be safely ignored) :)

@Jibec

This comment has been minimized.

Copy link
Collaborator

Jibec commented Feb 8, 2019

I'm working on this, the way to make it work is to take line by line the new nginx template and adapt it with YunoHost specifics: https://dev.funkwhale.audio/funkwhale/funkwhale/blob/0.18.1/deploy/nginx.template

but once done, we stil have an issue:
requests.exceptions.SSLError: HTTPSConnectionPool(host='ff.jb9.fr', port=443): Max retries exceeded with url: /front/index.html (Caused by SSLError(SSLError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:720)'),))

the API calls the server, nginx force it to be https and django cries because it's a selfsign certificate and it crashes.

Eliot said he would help to fix this.

@PierrickBrun

This comment has been minimized.

Copy link
Author

PierrickBrun commented Feb 8, 2019

@Jibec

This comment has been minimized.

Copy link
Collaborator

Jibec commented Feb 8, 2019

@EliotBerriot

This comment has been minimized.

Copy link
Collaborator

EliotBerriot commented Feb 9, 2019

Hi there, sorry for the issue!

I've published a fix for that yesterday, and if you use this commit you can now specify the env var FUNKWHALE_SPA_HTML_ROOT=/srv/funkwhale/front/dist/index.html to bypass this network request completely.

Replace /srv/funkwhale/front/dist/index.html by the actual path of the front-end index.html file with the Yunohost setup :)

@Jibec

This comment has been minimized.

Copy link
Collaborator

Jibec commented Feb 13, 2019

looks like fixed upstream, https://docs.funkwhale.audio/changelog.html#id1, I'll try this soon
Note to @EliotBerriot : the anchors are "id1" "id2", "id3", meaning we can't make semi-permanent link as for each release, the correct will change

@EliotBerriot

This comment has been minimized.

Copy link
Collaborator

EliotBerriot commented Feb 14, 2019

@Jibec yeah that's a limitation of our current documentation system :s

@Jibec

This comment has been minimized.

Copy link
Collaborator

Jibec commented Feb 17, 2019

it should be ready to test, please provide feedback 👍

@Jibec

This comment has been minimized.

Copy link
Collaborator

Jibec commented Mar 2, 2019

@EliotBerriot I'm merging this now, please test and confirm it works fine for you

@Jibec Jibec merged commit b858d77 into YunoHost-Apps:testing Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.