Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #9

Open
wants to merge 16 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@JimboJoe
Copy link

commented Mar 10, 2019

Problem

  • Global upgrade of the package.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis and others added some commits Apr 11, 2018

Merge pull request #7 from YunoHost-Apps/Add-upgrade-from-a-previous-…
…commit

Add upgrade from a previous commit
Create pull_request_template.md
Duplicated from YunoHost-Apps/searx_ynh#35, merged as a micro decision
Merge pull request #8 from YunoHost-Apps/package_upgrade
Normalization from example_ynh

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Mar 10, 2019

@JimboJoe

This comment has been minimized.

Copy link
Author

commented Mar 10, 2019

Proposing to merge that testing promptly after your review...

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

LGTM :D ?

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group Mar 10, 2019

@kay0u
Copy link
Member

left a comment

LGTM and code review 👍

@kay0u

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Will be merged in 3 days.
Oups

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2019

We actually need one more review, I can't review my own code.

@maniackcrudelis maniackcrudelis dismissed stale reviews from kay0u and themself via 92c5a52 Mar 24, 2019

maniackcrudelis added some commits Apr 15, 2019

Merge pull request #11 from YunoHost-Apps/package_upgrade
Normalization from example_ynh

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group May 12, 2019

@kay0u

kay0u approved these changes May 13, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Apparently we got a review ;)

@kay0u

This comment has been minimized.

Copy link
Member

commented May 21, 2019

One more O.O

@JimboJoe

This comment has been minimized.

Copy link
Author

commented May 22, 2019

Hm... let's say I approve (I'm the PR originator)...? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.