Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalization from example_ynh #56

Merged
merged 1 commit into from May 12, 2019
Merged

Normalization from example_ynh #56

merged 1 commit into from May 12, 2019

Conversation

maniackcrudelis
Copy link
Contributor

@maniackcrudelis maniackcrudelis commented May 6, 2019 •
edited by kay0u

Problem

  • Global upgrade of the package.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from a team May 6, 2019 12:15
JimboJoe
JimboJoe approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@JimboJoe JimboJoe requested a review from a team May 7, 2019 18:00
kay0u
kay0u approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kay0u
Copy link
Member

kay0u commented May 9, 2019

Will be merged in 3 days

@maniackcrudelis maniackcrudelis merged commit f9382a4 into testing May 12, 2019
@maniackcrudelis maniackcrudelis deleted the package_upgrade branch May 12, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maniackcrudelis @kay0u @JimboJoe