Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #25

Open
wants to merge 12 commits into
base: master
from

Conversation

@maniackcrudelis
Copy link
Collaborator

commented Jul 2, 2019

Solution

  • Use helpers from YunoHost 3.5
  • Global upgrade of the package
  • Use ynh_get_scalable_phpfpm to set a php config according to the server.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


  • Code review: Kay0u
  • Approval (LGTM): Kay0u
    Code review and approval have to be from a member of @YunoHost/apps group
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

kay0u and others added some commits Apr 8, 2019

Merge pull request #21 from YunoHost-Apps/package_upgrade
Normalization from example_ynh

@maniackcrudelis maniackcrudelis marked this pull request as ready for review Jul 10, 2019

@alexAubin
Copy link
Member

left a comment

Quick review, LGTM 👍

@alexAubin

This comment has been minimized.

Copy link
Member

commented Aug 17, 2019

Bump ... any love for this PR ? 😕

@kay0u

kay0u approved these changes Aug 18, 2019

Copy link
Member

left a comment

LGTM & code review (I haven't received any messages about this PR)

Can be merged in 3 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.