upgrade to 0.2.3 multi-device #38

Gredin67 · 2021-12-07T23:43:14Z

upgrade to 0.2.3 multi-device
Upgrade conf
Test and document consequences of new relaybot system with a portal-specific relay user option like in mautrix-signal. https://github.com/mautrix/whatsapp/releases
Use pre-build #37

PR Status

Package_check results

If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

Gredin67 · 2021-12-07T23:43:47Z

!testme

yunohost-bot · 2021-12-07T23:43:51Z

🌻

GonzaGoux · 2021-12-08T01:08:02Z

Hi! Is there any was I can test this new version on my Yunohost? Thanks! Gonza

Gredin67 · 2021-12-08T22:51:09Z

it is not ready yet, I'll let you know when it can be tested

* install pre-built

Gredin67 · 2021-12-13T23:43:09Z

Is there any was I can test this new version on my Yunohost? Thanks!

@GonzaGoux You can test it now by running:
sudo yunohost app install https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/tree/testing --debug
or
sudo yunohost app upgrade mautrix_whatsapp -u https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/tree/testing --debug

GonzaGoux · 2021-12-16T21:42:31Z

Hello @Gredin67 how are you doing? I installed in a server test with Yunohost. Installed well but the bot is not joining. Here is the log data. Hope it helps! Gonza

debian@instance-debian-yunohost:~$ sudo yunohost log show 20211216-212723-app_install-mautrix_whatsapp
description: Install the 'mautrix_whatsapp' app
log_path: /var/log/yunohost/categories/operation/20211216-212723-app_install-mautrix_whatsapp.log
logs:
  - 2021-12-16 21:28:31,164: DEBUG - + action=start
  - 2021-12-16 21:28:31,164: DEBUG - + line_match=
  - 2021-12-16 21:28:31,164: DEBUG - + length=20
  - 2021-12-16 21:28:31,165: DEBUG - + log_path=/var/log/mautrix_whatsapp/mautrix_whatsapp.log
  - 2021-12-16 21:28:31,165: DEBUG - + timeout=300
  - 2021-12-16 21:28:31,165: DEBUG - + '[' start == stop ']'
  - 2021-12-16 21:28:31,165: DEBUG - + [[ -n '' ]]
  - 2021-12-16 21:28:31,165: DEBUG - + '[' start == reload ']'
  - 2021-12-16 21:28:31,165: DEBUG - + systemctl start mautrix_whatsapp
  - 2021-12-16 21:28:31,185: DEBUG - + [[ -n '' ]]
  - 2021-12-16 21:28:31,185: DEBUG - + sleep 30
  - 2021-12-16 21:29:01,188: DEBUG - + '[' 1 = true ']'
  - 2021-12-16 21:29:01,188: DEBUG - + ynh_systemd_action --service_name=mautrix_whatsapp --action=restart
  - 2021-12-16 21:29:01,188: DEBUG - + local legacy_args=nalpte
  - 2021-12-16 21:29:01,189: DEBUG - + args_array=([n]=service_name= [a]=action= [l]=line_match= [p]=log_path= [t]=timeout= [e]=length=)
  - 2021-12-16 21:29:01,189: DEBUG - + local -A args_array
  - 2021-12-16 21:29:01,189: DEBUG - + local service_name
  - 2021-12-16 21:29:01,189: DEBUG - + local action
  - 2021-12-16 21:29:01,189: DEBUG - + local line_match
  - 2021-12-16 21:29:01,189: DEBUG - + local length
  - 2021-12-16 21:29:01,189: DEBUG - + local log_path
  - 2021-12-16 21:29:01,189: DEBUG - + local timeout
  - 2021-12-16 21:29:01,189: DEBUG - + ynh_handle_getopts_args --service_name=mautrix_whatsapp --action=restart
  - 2021-12-16 21:29:01,189: DEBUG - + set +o xtrace
  - 2021-12-16 21:29:01,285: DEBUG - + service_name=mautrix_whatsapp
  - 2021-12-16 21:29:01,285: DEBUG - + action=restart
  - 2021-12-16 21:29:01,285: DEBUG - + line_match=
  - 2021-12-16 21:29:01,285: DEBUG - + length=20
  - 2021-12-16 21:29:01,285: DEBUG - + log_path=/var/log/mautrix_whatsapp/mautrix_whatsapp.log
  - 2021-12-16 21:29:01,285: DEBUG - + timeout=300
  - 2021-12-16 21:29:01,285: DEBUG - + '[' restart == stop ']'
  - 2021-12-16 21:29:01,286: DEBUG - + [[ -n '' ]]
  - 2021-12-16 21:29:01,286: DEBUG - + '[' restart == reload ']'
  - 2021-12-16 21:29:01,286: DEBUG - + systemctl restart mautrix_whatsapp
  - 2021-12-16 21:29:01,366: DEBUG - + [[ -n '' ]]
  - 2021-12-16 21:29:01,366: DEBUG - + ynh_script_progression '--message=Installation of mautrix_whatsapp completed' --last
  - 2021-12-16 21:29:01,366: DEBUG - + set +o xtrace
  - 2021-12-16 21:29:01,669: DEBUG - + set +o xtrace
  - 2021-12-16 21:29:01,687: DEBUG - + echo '! Helper used in legacy mode !'
  - 2021-12-16 21:29:01,688: DEBUG - + set +x
  - 2021-12-16 21:29:01,689: DEBUG - + echo '[####################] > Installation of mautrix_whatsapp completed'
  - 2021-12-16 21:29:01,689: DEBUG - + set -o xtrace
  - 2021-12-16 21:29:01,689: DEBUG - + ynh_exit_properly
  - 2021-12-16 21:29:01,690: DEBUG - + local exit_code=0
  - 2021-12-16 21:29:01,690: DEBUG - + rm -rf /var/cache/yunohost/download/
  - 2021-12-16 21:29:01,690: INFO - [####################] > Installation of mautrix_whatsapp completed
  - 2021-12-16 21:29:01,691: DEBUG - + '[' 0 -eq 0 ']'
  - 2021-12-16 21:29:01,691: DEBUG - + exit 0
  - 2021-12-16 21:29:02,693: DEBUG - Checking that required services are up and running...
  - 2021-12-16 21:29:05,885: SUCCESS - Installation completed
metadata:
  args:
    app: https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/tree/testing
    args: None
    force: False
    label: None
    no_remove_on_failure: False
  ended_at: 2021-12-16 21:29:05
  env:
    YNH_APP_ARG_BOTADMIN: Your main Matrix account
    YNH_APP_ARG_BOTUSERS: Admin
    YNH_APP_ARG_BOT_SYNAPSE_ADM: 1
    YNH_APP_ARG_ENCRYPTION: 0
    YNH_APP_ARG_SYNAPSENUMBER: 1
    YNH_APP_ARG_WHATSAPPBOT: whatsappbot
    YNH_APP_BASEDIR: /var/cache/yunohost/app_tmp_work_dirs/app_qb90tfjo
    YNH_APP_ID: mautrix_whatsapp
    YNH_APP_INSTANCE_NAME: mautrix_whatsapp
    YNH_APP_INSTANCE_NUMBER: 1
    YNH_APP_MANIFEST_VERSION: 0.2.1~ynh1
    YNH_ARCH: amd64
  error: None
  interface: cli
  operation: app_install
  parent: None
  related_to:
    - app
    - mautrix_whatsapp
  started_at: 2021-12-16 21:27:23
  success: True
  yunohost_version: 4.3.4.2
metadata_path: /var/log/yunohost/categories/operation/20211216-212723-app_install-mautrix_whatsapp.yml
name: 20211216-212723-app_install-mautrix_whatsapp

Gredin67 · 2021-12-20T21:40:22Z

My guess is that you have to authorize your matrix user to use the bridge in config.yaml

Gredin67 · 2021-12-20T22:43:16Z

well, same issue here, I need to debug this

nathanael-h · 2021-12-30T06:43:52Z

!testme

yunohost-bot · 2021-12-30T06:43:54Z

🌻

nathanael-h · 2021-12-30T06:45:57Z

Just triggered a ci build. How are tests running on your server @Gredin67 @GonzaGoux ? Do you need more tests?
+1 for using prebuilt binaires ;)

Gredin67 · 2021-12-30T10:36:34Z

it is installing properly, but the bot is not responding, and the logs are empty. There must be some issue/ difference in the pre-built with respect to the built approach. It was a bad idea to both switch to pre-built and upgrade to multi-device in one row. It makes debugging complex...

nathanael-h · 2021-12-30T18:27:31Z

Indeed it is not so easy to find the root cause of the failure...
I read the official docs, there is no diff if we build or use prebuilt binaries.
As per changelog the config file should be updated, did you see this?

Many config fields have been changed/renamed/removed, so it is recommended to look through the example config and update your config.

https://github.com/mautrix/whatsapp/releases/tag/v0.2.0

Édit : i wrote too fast, i just saw you updated the config file

nathanael-h · 2021-12-30T21:37:35Z

I tried to update on testing and got an error. Here are logs : https://paste.yunohost.org/raw/ogopoxipuy
The relevant part is:

2021-12-30 22:23:27,900: DEBUG - + /opt/yunohost/mautrix_whatsapp/mautrix-whatsapp -g -c /opt/yunohost/mautrix_whatsapp/config.yaml -r /etc/matrix-synapse/app-service/mautrix_whatsapp.yaml
2021-12-30 22:23:27,901: WARNING - ./upgrade: line 176: /opt/yunohost/mautrix_whatsapp/mautrix-whatsapp: Permission denied

Should we do in upgrade like it is done in install ⬇️ ?

chown $mautrix_whatsapp_user:root -R $final_path
chmod 750 $final_path/mautrix-whatsapp

(maybe 750 instead of 755?)

nathanael-h · 2021-12-31T12:27:53Z

Just did this small PR #41 ; if you prefer I could push directly to testing or another branch in this repo. I'd just need rights to do it.

Gredin67 · 2022-01-02T14:10:40Z

don't get why it used to work https://ci-apps-dev.yunohost.org/ci/job/4109
I re-run the CI because this is strange https://ci-apps-dev.yunohost.org/ci/job/4252

nathanael-h · 2022-01-02T15:06:00Z

conf/config.yaml

    # Log file permissions.
-    file_mode: 0600
+    file_mode: 0o600


I think there is a conflict with this and the systemd.service.
Here we tell the app to check and fix if needed that de log file is owned by the user running the bridge (default is mautrix_whatsapp) and the perms are 600.

In the systemd service with redirect output to the same file so it is first created by root on service starting.
https://github.com/YunoHost-Apps/mautrix_whatsapp_ynh/blob/testing/conf/systemd.service#L9

I saw with strace that when the bridge stars it loops on something related to the log file (I did not understand all the strace output by the way 😅 ). I tried to remove the output in the systemd file and it seems to let de bot starts.

still not working although erasing the log worked once. After restarting the bridge, it does not start properly. If you manage to solve this permission issue I would be greatful :)
@zamentur which chmod and chown should we set for the bridge logs and how to get the bridge happy with it in config.yaml?

Gredin67 · 2022-01-19T08:35:19Z

!testme

yunohost-bot · 2022-01-19T08:35:22Z

😜

Gredin67 · 2022-01-21T11:04:00Z

I would merge today if nobody opposes

alexAubin

Super quick review, LGTM

upgrade to 0.2.1 conf etc..

00a2bed

install pre-built (#39)

798fc49

* install pre-built

Gredin67 added 8 commits December 23, 2021 00:18

Update amd64.src

9330d85

config 0.2.2

25a678e

user as domain

289b44f

Update amd64.src

1ad8f31

Update install

f75c8a6

Update install

703de65

execute mautrix-whatsapp

d998ff9

execution rights

8592860

This was referenced Dec 31, 2021

e2be is not configured, like AT ALL YunoHost-Apps/mautrix_telegram_ynh#15

Closed

e2be is not configured, like AT ALL YunoHost-Apps/mautrix_signal_ynh#35

Closed

execution rights

1675bcb

nathanael-h reviewed Jan 2, 2022

View reviewed changes

Gredin67 added 2 commits January 18, 2022 19:00

Update arm64.src

3129ffe

Update armhf.src

11edfed

Gredin67 changed the title ~~upgrade to 0.2.1 multi-device~~ upgrade to 0.2.3 multi-device Jan 18, 2022

Gredin67 added 6 commits January 18, 2022 19:40

Update amd64.src

35c6610

Update arm64.src

4c3a702

Update armhf.src

b87ef78

Update amd64.src

974c331

Update arm64.src

e398f12

Update armhf.src

872280f

Gredin67 added 5 commits January 21, 2022 09:31

back to github release

4c4d550

back to github releases

f6edbbf

Update armhf.src

eac46d7

Update arm64.src

03cb537

Update check_process

95e5f78

Gredin67 requested a review from nathanael-h January 21, 2022 11:03

Update manifest.json

3d188ec

alexAubin approved these changes Jan 21, 2022

View reviewed changes

Gredin67 added 8 commits January 21, 2022 15:28

Update manifest.json

ea14000

Update manifest.json

5ee3d6a

Update manifest.json

ccafa3d

Update upgrade

bd2a6cc

Update upgrade

58aec03

Update remove

64efd06

Update upgrade

f06c84e

instruction new relaybot

b23c77e

Gredin67 merged commit 8d95063 into master Jan 25, 2022

Gredin67 deleted the testing branch February 2, 2022 10:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upgrade to 0.2.3 multi-device #38

upgrade to 0.2.3 multi-device #38

Gredin67 commented Dec 7, 2021 •

edited

Gredin67 commented Dec 7, 2021

yunohost-bot commented Dec 7, 2021

GonzaGoux commented Dec 8, 2021

Gredin67 commented Dec 8, 2021

Gredin67 commented Dec 13, 2021 •

edited

GonzaGoux commented Dec 16, 2021

Gredin67 commented Dec 20, 2021

Gredin67 commented Dec 20, 2021

nathanael-h commented Dec 30, 2021

yunohost-bot commented Dec 30, 2021

nathanael-h commented Dec 30, 2021

Gredin67 commented Dec 30, 2021

nathanael-h commented Dec 30, 2021 •

edited

nathanael-h commented Dec 30, 2021

nathanael-h commented Dec 31, 2021 •

edited

Gredin67 commented Jan 2, 2022

nathanael-h Jan 2, 2022

Gredin67 Jan 5, 2022

Gredin67 commented Jan 19, 2022

yunohost-bot commented Jan 19, 2022

Gredin67 commented Jan 21, 2022

alexAubin left a comment

upgrade to 0.2.3 multi-device #38

upgrade to 0.2.3 multi-device #38

Conversation

Gredin67 commented Dec 7, 2021 • edited

PR Status

Package_check results

Gredin67 commented Dec 7, 2021

yunohost-bot commented Dec 7, 2021

GonzaGoux commented Dec 8, 2021

Gredin67 commented Dec 8, 2021

Gredin67 commented Dec 13, 2021 • edited

GonzaGoux commented Dec 16, 2021

Gredin67 commented Dec 20, 2021

Gredin67 commented Dec 20, 2021

nathanael-h commented Dec 30, 2021

yunohost-bot commented Dec 30, 2021

nathanael-h commented Dec 30, 2021

Gredin67 commented Dec 30, 2021

nathanael-h commented Dec 30, 2021 • edited

nathanael-h commented Dec 30, 2021

nathanael-h commented Dec 31, 2021 • edited

Gredin67 commented Jan 2, 2022

nathanael-h Jan 2, 2022

Choose a reason for hiding this comment

Gredin67 Jan 5, 2022

Choose a reason for hiding this comment

Gredin67 commented Jan 19, 2022

yunohost-bot commented Jan 19, 2022

Gredin67 commented Jan 21, 2022

alexAubin left a comment

Choose a reason for hiding this comment

Gredin67 commented Dec 7, 2021 •

edited

Gredin67 commented Dec 13, 2021 •

edited

nathanael-h commented Dec 30, 2021 •

edited

nathanael-h commented Dec 31, 2021 •

edited