Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail2ban configuration (closes #39) #182

Merged
merged 2 commits into from Apr 2, 2019

Conversation

Projects
None yet
3 participants
@JimboJoe
Copy link
Contributor

commented Mar 24, 2019

Problem

  • This application could benefit from fail2ban

Solution

  • *Add fail2ban configuration (following work on #40) *

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Mar 24, 2019

@JimboJoe JimboJoe referenced this pull request Mar 24, 2019

Closed

Add fail2ban configuration (closes #39) #40

0 of 10 tasks complete
@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

I have to ask... Did you test it ?

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

An interesting argument with --failregex to test the robustness of getopts by the way.
I confirm that it works perfectly, the string is rendered as ask into the config file.

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Mar 25, 2019

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

Yep, was tested OK (as in the checkbox 😛 ) 👍

@kay0u

kay0u approved these changes Mar 25, 2019

Copy link
Member

left a comment

LGTM

@kay0u
Copy link
Member

left a comment

You can add this help in _common.sh, or use systemctl restart fail2ban

Show resolved Hide resolved scripts/restore

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Mar 25, 2019

@kay0u

kay0u approved these changes Mar 25, 2019

Copy link
Member

left a comment

LGTM 👍

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Will be merged in 3 days.

@JimboJoe JimboJoe merged commit 5a521bd into testing Apr 2, 2019

@JimboJoe JimboJoe deleted the enh_fail2ban branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.