Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #57

Merged
merged 3 commits into from May 16, 2019

Conversation

Projects
None yet
5 participants
@JimboJoe
Copy link
Contributor

commented Apr 9, 2019

Problem

  • The application is not up-to-date

Solution

  • Upgrade to latest version 1.3.9

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

JimboJoe added some commits Apr 6, 2019

Merge pull request #55 from YunoHost-Apps/enh_update_1.3.9
Upgrade to upstream version 1.3.9
@zamentur

This comment has been minimized.

Copy link

commented Apr 30, 2019

There is an important bug in master version (see https://forum.yunohost.org/t/roudcube-bouton-envoye-innactif-postfix-connection-refused/7614/11 ) I suggest to keep this testing small as possible to merge it quickly

@zamentur

This comment has been minimized.

Copy link

commented Apr 30, 2019

I have reviewed the code. It seems ok.

@zamentur

This comment has been minimized.

Copy link

commented Apr 30, 2019

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

Looks like that PR has been forgotten. Or maybe it was on purpose?

Ready to be reviewed, if @JimboJoe agree.

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group Apr 30, 2019

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented Apr 30, 2019

I do agree 😉

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

I was asking mainly because I think we do not have any feedback from this testing.

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

@zamentur the forum post here doesn't seem so positive about this upgrade...

@kay0u

kay0u approved these changes May 2, 2019

@kay0u

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Can be merged in 3 days

@alexAubin

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Bump folks, apparently this could be merged in 3 days, 15 days ago ? (Can I click the button 👀 ? )

@kay0u

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Sorry, but this is MY button.

@kay0u kay0u merged commit 9640c23 into master May 16, 2019

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

@kay0u The button to post about the stable release in the roundcube dedicated thread on the forum is yours as well, I presume... 😜

@kay0u

This comment has been minimized.

Copy link
Member

commented May 16, 2019

It's done, sorry I never pushed that button before .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.