Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #143

Open
wants to merge 10 commits into
base: master
from

Conversation

@kay0u
Copy link
Member

commented Jul 30, 2019

Problem

  • IPV6 typo

Solution

  • Fix IPV6 typo

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

nicofrand and others added some commits Jul 23, 2019

Update manifest.json
Co-Authored-By: Mayeul Cantan <mayeul.cantan@gmail.com>
Merge pull request #137 from nicofrand/testing
Fix typo in IP6 validation
@Thatoo

This comment has been minimized.

Copy link

commented Jul 31, 2019

aha, I've just discovered how to let you know I have reviewed and approved changes. Might look small but it makes me happy to participate. Little by little I'm learning github. Thank you all.

@alexAubin
Copy link
Member

left a comment

Sounds like a very small change, yolomerge ? :S

@Josue-T Josue-T dismissed stale reviews from alexAubin and Thatoo via 7382146 Aug 5, 2019

@Thatoo

Thatoo approved these changes Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.