Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #60

Open
wants to merge 19 commits into
base: master
from

Conversation

@kay0u
Copy link
Member

commented Jun 1, 2019

Problem

  • Global upgrade of the package.
  • Add change_url script
  • Update nginx.conf to allow bigger torrent uploads

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis and others added some commits Apr 15, 2019

Do not remove data directory
Prevent losing data in case of reinstallation.
Data can be removed from the multimedia directory
@kay0u kay0u referenced this pull request Jun 1, 2019
0 of 8 tasks complete

notarobot63 and others added some commits Jun 3, 2019

Update nginx.conf
PR to allow upload of bigger torrent files
On files >1M you got the "Entity too large" nginx error
This can be fixed by using : client_max_body_size 8M;
Merge pull request #61 from notarobot63/testing
Update nginx.conf to allow biggger torrent uploads
Merge pull request #62 from YunoHost-Apps/NoSuchUnit
Move code to avoid a warning during the remove

@kay0u kay0u requested a review from YunoHost-Apps/apps-group Jun 18, 2019

@Gofannon

This comment has been minimized.

Copy link

commented Jul 7, 2019

bump

@alexAubin
Copy link
Member

left a comment

Otherwise kind of LGTM

conf/nginx.conf Show resolved Hide resolved
@alexAubin
Copy link
Member

left a comment

LGTM then ?

@kay0u

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2019

Bump

@alexAubin

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

Just ran the upgrade on my instance and everything went well ... Let'seuh goh

@JimboJoe
Copy link
Contributor

left a comment

LGTM 👍

@JimboJoe

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

Can be merged in 3 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.