Testing #109
Testing #109
Conversation
* Update manifest.json
* Add ynh_add_config
This reverts commit d68f41c.
Co-authored-by: Yunohost-Bot <>
Fix files permissions
Patches that allows to connect to the app without authentication are not working anymore. I see 3 possible solutions: - rework patches to work with upstream changes - use built-in authentication - set authentication to false and protect app access with SSO (as in this PR)
|
!testme |
|
Meow 🐈 |
|
!testme |
|
🎠 |
conf/config.php
Outdated
| // to decrypt. | ||
|
|
||
| define('SINGLE_USER_MODE', false); | ||
| putenv('TTRSS_SINGLE_USER_MODE=true'); |
There was a problem hiding this comment.
Seems very strange to activate that ?
What happens for instances with multiple user ?
There was a problem hiding this comment.
Patches that allows to connect to the app without authentication are not working anymore.
I see 3 possible solutions:
- rework patches to work with upstream changes
- use built-in authentication
- set authentication to false and protect app access with SSO (as in this PR)
I am unable to fix the current patchs to the upstream changes.
TTRSS_SINGLE_USER_MODE was changed to false so we can have the built-in authentication
There was a problem hiding this comment.
Quick review, LGTM
What happend to the discussion regarding auth / singleuser mode that you were discussing in #109 (comment) in the end ?
|
ttrss uses a built-in authentication. This used to be bypassed by a (not-working-anymore) patch. |
|
!testme |
|
Fingers crossed! |
|
Shall we merge this? |
|
!testme |
|
Meow 🐈 |
Problem
Solution
PR Status
Automatic tests
Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)