Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify change_url script by using newly accessible conf folder #50

Merged
merged 3 commits into from Jun 26, 2018

Conversation

Projects
None yet
4 participants
@JimboJoe
Copy link
Contributor

commented May 26, 2018

Problem

  • Latest changes in core allow to use package conf file in change_url script, thus simplifying it
  • Some web ressources aren't available after changing URL (#48)

Solution

  • Depend on YunoHost 2.7.12 and simplify change_url script
  • Clear assets cache after changing URL

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) : Lapineige (maintainer)
  • CI succeeded :
    Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group May 26, 2018

@lapineige

This comment has been minimized.

Copy link
Member

commented May 27, 2018

I did not tested it yet, but it looks good to me.

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2018

The CI build is failing because of something that looks like a bad conflict resolution, that doesn't appear in the changes here... but I can't log into the server to look into this 😇

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2018

Much better after @maniackcrudelis' fix on CI, thanks!

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2018

Code review Ok

@lapineige

This comment has been minimized.

Copy link
Member

commented Jun 4, 2018

@JimboJoe if it's ok for you, let's merge in 3 days ?

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Jun 4, 2018

@Josue-T

Josue-T approved these changes Jun 4, 2018

@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2018

I guess we can... 😇

@lapineige

This comment has been minimized.

Copy link
Member

commented Jun 26, 2018

Let's merge :)

@lapineige lapineige merged commit d6a9721 into testing Jun 26, 2018

@lapineige lapineige deleted the enh_simplify_change_url branch Jun 26, 2018

@maniackcrudelis maniackcrudelis referenced this pull request Jun 26, 2018

Closed

Testing #52

4 of 8 tasks complete

@maniackcrudelis maniackcrudelis restored the enh_simplify_change_url branch Jun 29, 2018

maniackcrudelis added a commit that referenced this pull request Jun 29, 2018

@maniackcrudelis maniackcrudelis deleted the enh_simplify_change_url branch Jun 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.