Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #56

Merged
merged 2 commits into from Dec 17, 2018

Conversation

Projects
None yet
6 participants
@lapineige
Copy link
Member

commented Aug 29, 2018

Problem

  • Fix 413 Request Entity Too Large (#55)

Solution

  • Allows to upload larger file, for instance to transfer a backup

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) : Josué
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.
Fix 413 request entity too large (#55)
* [fix] 413 Request Entity Too Large

@lapineige lapineige requested review from JimboJoe and YunoHost-Apps/wallabag-v2 Aug 29, 2018

@lapineige

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2018

The only commit was already approved. Let's merge in 3 days ?

@JimboJoe

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

The process implies advertising the testing release on the forum, and open reviews after one week 😉

@JimboJoe JimboJoe added the pending label Aug 29, 2018

@JimboJoe JimboJoe requested review from YunoHost-Apps/apps-group and removed request for YunoHost-Apps/wallabag-v2 Aug 29, 2018

@lapineige

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2018

Oh yeah you're right 😅
(I'll do it later, too busy now)

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

Ready to be reviewed.

@quentinDupont
Copy link

left a comment

Tested on Yunohost 3.3.3 👍

@lapineige lapineige merged commit 06be7ae into master Dec 17, 2018

@lapineige

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

Tested, it works fine.

lapineige added a commit that referenced this pull request May 8, 2019

Add Fail2ban support (#65)
* Readme: Add welcome UI screenshoot 

It's always nice to have a quick look at the UI of the software you're going to install :)

* Testing  (#56)

* Fix 413 request entity too large (#55)

* [fix] 413 Request Entity Too Large

* Remove ini file for php (#57)

Have a look to YunoHost-Apps/nextcloud_ynh#138 for more information

* Add fail2ban config

* Add Fail2ban config removal helper

* Enhance fail2ban config look

* Add fail2ban backup

* Restore fail2ban config

* Add fail2ban config during upgrade

To make sure any older version will get fail2ban support

* Update minimum version to 3.5

This is needed for fail2ban helpers

* Add fail2ban info

* Fail2ban: Fix missing log file during install

* Fix feil2ban regex

* Fix fail2ban regex - 2

* Use ynh_systemd_action

* Use long getopts arguments

* Fix duplicated comment and remove blank space

* Fix fail2ban regex in upgrade script

* Improve regex - install

This allow empty username (not possible, but may still block some extra brute force spammers) and username with spaces

* Improve regex - upgrade

This allow empty username (not possible, but may still block some extra brute force spammers) and username with spaces

* Fix missing log file for fail2ban

* Indentation and variable usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.