Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ini file for php #57

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@maniackcrudelis
Copy link
Contributor

commented Oct 1, 2018

Problem

Solution

  • Get rid of the ini file and merge its content into the pool file.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Josué
  • Approval (LGTM) : Josué
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group Oct 1, 2018

@lapineige lapineige self-requested a review Oct 2, 2018

@lapineige

This comment has been minimized.

Copy link
Member

commented Oct 2, 2018

I don't know how to test this specific change, but installation and so on work. Uploading a file bigger than 50MB is still impossible so I guess it's working.

@Josue-T

Josue-T approved these changes Oct 2, 2018

@lapineige lapineige merged commit b305551 into testing Oct 2, 2018

@lapineige lapineige deleted the remove_php_ini branch Oct 2, 2018

lapineige added a commit that referenced this pull request Dec 17, 2018

Testing (#56)
* Fix 413 request entity too large (#55)

* [fix] 413 Request Entity Too Large

* Remove ini file for php (#57)

Have a look to YunoHost-Apps/nextcloud_ynh#138 for more information

lapineige added a commit that referenced this pull request May 8, 2019

Add Fail2ban support (#65)
* Readme: Add welcome UI screenshoot 

It's always nice to have a quick look at the UI of the software you're going to install :)

* Testing  (#56)

* Fix 413 request entity too large (#55)

* [fix] 413 Request Entity Too Large

* Remove ini file for php (#57)

Have a look to YunoHost-Apps/nextcloud_ynh#138 for more information

* Add fail2ban config

* Add Fail2ban config removal helper

* Enhance fail2ban config look

* Add fail2ban backup

* Restore fail2ban config

* Add fail2ban config during upgrade

To make sure any older version will get fail2ban support

* Update minimum version to 3.5

This is needed for fail2ban helpers

* Add fail2ban info

* Fail2ban: Fix missing log file during install

* Fix feil2ban regex

* Fix fail2ban regex - 2

* Use ynh_systemd_action

* Use long getopts arguments

* Fix duplicated comment and remove blank space

* Fix fail2ban regex in upgrade script

* Improve regex - install

This allow empty username (not possible, but may still block some extra brute force spammers) and username with spaces

* Improve regex - upgrade

This allow empty username (not possible, but may still block some extra brute force spammers) and username with spaces

* Fix missing log file for fail2ban

* Indentation and variable usage

@maniackcrudelis maniackcrudelis referenced this pull request May 13, 2019

Merged

Testing #70

7 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.