Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization from example_ynh #67

Merged
merged 4 commits into from May 13, 2019

Conversation

Projects
None yet
4 participants
@maniackcrudelis
Copy link
Contributor

commented May 3, 2019

Problem

  • Global upgrade of the package.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group May 3, 2019

@lapineige lapineige self-requested a review May 3, 2019

@lapineige lapineige added this to In progress in New apps Packaging via automation May 3, 2019

@lapineige lapineige removed this from In progress in New apps Packaging May 3, 2019

@lapineige

This comment has been minimized.

Copy link
Member

commented May 3, 2019

Thanks a lot @maniackcrudelis for this great PR !

I'll take some time to review it in details and test it, but LGTM at first look :)

@lapineige lapineige requested a review from JimboJoe May 3, 2019

@JimboJoe JimboJoe referenced this pull request May 5, 2019

Merged

Update to 2.3.7 #61

7 of 8 tasks complete
@JimboJoe
Copy link
Contributor

left a comment

LGTM and code review OK 👍

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group May 5, 2019

@lapineige

This comment has been minimized.

Copy link
Member

commented May 5, 2019

I just added some extra details in the readme, sorry for dismissing the review :/

@lapineige
Copy link
Member

left a comment

LGTM :)

@lapineige

This comment has been minimized.

Copy link
Member

commented May 8, 2019

I fixed the conflicts, I hope I respected all your changes.

@kay0u

kay0u approved these changes May 9, 2019

Copy link
Member

left a comment

LGTM

@JimboJoe

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Can be merged in 3 days.

@kay0u kay0u merged commit d2725a2 into testing May 13, 2019

@kay0u kay0u deleted the package_upgrade branch May 13, 2019

@maniackcrudelis maniackcrudelis referenced this pull request May 13, 2019

Merged

Testing #70

7 of 8 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.