Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #70

Open
wants to merge 26 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@maniackcrudelis
Copy link
Contributor

commented May 13, 2019

Problem

  • Fix an issue when you try to import wallabag articles #55
  • Remove ini file for php #57
  • Upgrade to 2.3.8 #71
  • Wallabag is not protected by fail2ban against brute force #65
  • Global upgrade of the package #67
  • Cache files are included in the backup (useless space usage) #60

Solution

  • Add fail2ban config
  • Don't save the cache during backup (delete it) #71

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : @lapineige
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

zamentur and others added some commits Aug 23, 2018

Fix 413 request entity too large (#55)
* [fix] 413 Request Entity Too Large
Add Fail2ban support (#65)
* Readme: Add welcome UI screenshoot 

It's always nice to have a quick look at the UI of the software you're going to install :)

* Testing  (#56)

* Fix 413 request entity too large (#55)

* [fix] 413 Request Entity Too Large

* Remove ini file for php (#57)

Have a look to YunoHost-Apps/nextcloud_ynh#138 for more information

* Add fail2ban config

* Add Fail2ban config removal helper

* Enhance fail2ban config look

* Add fail2ban backup

* Restore fail2ban config

* Add fail2ban config during upgrade

To make sure any older version will get fail2ban support

* Update minimum version to 3.5

This is needed for fail2ban helpers

* Add fail2ban info

* Fail2ban: Fix missing log file during install

* Fix feil2ban regex

* Fix fail2ban regex - 2

* Use ynh_systemd_action

* Use long getopts arguments

* Fix duplicated comment and remove blank space

* Fix fail2ban regex in upgrade script

* Improve regex - install

This allow empty username (not possible, but may still block some extra brute force spammers) and username with spaces

* Improve regex - upgrade

This allow empty username (not possible, but may still block some extra brute force spammers) and username with spaces

* Fix missing log file for fail2ban

* Indentation and variable usage
Update to 2.3.7 (#61)
* Change version to 2.3.6

* Update to 2.3.6

* Update to 2.3.6

* Update to 2.3.7

* Update to 2.3.7

* Change version to 2.3.7

* Change version to 2.3.7 - fix French version

* Update custom patches
Exclude cache file from backup
It deletes them - it's simpler that not using the helper to backup the files.
Merge pull request #67 from YunoHost-Apps/package_upgrade
Normalization from example_ynh
@lapineige

This comment has been minimized.

Copy link
Member

commented May 13, 2019

What a big testing, since august 😄

Should we wait for #69 too ?

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

If #69 is merged before the 7 usual days, we could include it, otherwise I don't think we should "wait" for it.

lapineige added some commits May 14, 2019

@lapineige lapineige referenced this pull request May 14, 2019

Merged

Update to 2.3.8 #71

4 of 8 tasks complete
@kay0u

This comment has been minimized.

Copy link
Member

commented on c397bd1 May 15, 2019

Ok, but, why this "-1" after the version number?

This comment has been minimized.

Copy link
Member Author

replied May 15, 2019

I don't know. @JimboJoe ?

This comment has been minimized.

Copy link
Contributor

replied May 16, 2019

I see no reason...

This comment has been minimized.

Copy link
Member Author

replied May 16, 2019

How did we had that ? 😅

@lapineige

This comment has been minimized.

Copy link
Member

commented May 15, 2019

I already have some positive feedbacks.
My test went well too.

lapineige and others added some commits May 16, 2019

Fix version number
Useless "-1"

@maniackcrudelis maniackcrudelis marked this pull request as ready for review May 20, 2019

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group May 20, 2019

@lapineige lapineige requested review from lapineige and JimboJoe May 20, 2019


### `ynh_setup_source` is used to install an app from a zip or tar.gz file,
### downloaded from an upstream source, like a git repository.
### `ynh_setup_source` use the file conf/app.src

This comment has been minimized.

Copy link
@kay0u

kay0u May 21, 2019

Member

Please remove these lines

(Impossible to commit with my phone right now /o\)

This comment has been minimized.

Copy link
@lapineige

This comment has been minimized.

Copy link
@kay0u
@kay0u

kay0u approved these changes May 21, 2019

Copy link
Member

left a comment

LGTM & code review

@lapineige

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Upgrade from previous version works fine.
Fresh install too.
I didn't test the backup+restore yet, but the CI is passing.

@lapineige

This comment has been minimized.

Copy link
Member

commented May 21, 2019

LGTM & code review.

Let's merge in 3 days ?

@kay0u

This comment has been minimized.

Copy link
Member

commented May 24, 2019

There's still one LGTM missing from the apps group

@lapineige lapineige requested a review from YunoHost-Apps/apps-group May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.