Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #85

Open
wants to merge 18 commits into
base: master
from
Open

Testing #85

wants to merge 18 commits into from

Conversation

@maniackcrudelis
Copy link
Collaborator

maniackcrudelis commented Jan 31, 2020

Problem

  • No changelog
  • Change is_public was not working as expected
  • No actions and config_panel yet
  • Php is configured with a default config
  • App not up to date
  • wp-fail2ban plugin is becoming a premium plugin with a recurrent ads about going to the premium version. And the main dev of this plugin seems to not care about it.

Solution

  • Add a changelog
  • is_public is either 1 or 0 (not true of false)
  • Add an action for public/private and a config-panel
  • Use ynh_get_scalable_phpfpm to set php according to the ram, cpu and expected usage.
  • Update to 5.3.2
  • Remove wp-fail2ban and replace it by wp-fail2ban-redux.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.
maniack and others added 18 commits Dec 9, 2019
Replace wp fail2ban
Update to 5.3.2
Use ynh_get_scalable_phpfpm
Add action and config-panel feature
fix config is_public
Add changelog
@maniackcrudelis maniackcrudelis marked this pull request as ready for review Feb 7, 2020
@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group Feb 7, 2020
@maniackcrudelis

This comment has been minimized.

Copy link
Collaborator Author

maniackcrudelis commented Feb 7, 2020

Ready for review

@kay0u
kay0u approved these changes Feb 7, 2020
Copy link
Member

kay0u left a comment

LGTM & code review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.