Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #55

Merged
merged 13 commits into from May 16, 2019

Conversation

Projects
None yet
4 participants
@maniackcrudelis
Copy link
Contributor

commented Apr 10, 2019

Problem

Solution

  • *"true" -> true 馃槈 *

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : JimboJoe
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis and others added some commits Feb 13, 2019

Merge pull request #54 from YunoHost-Apps/optional-is-boolean
Value for "optional" should be a boolean

@maniackcrudelis maniackcrudelis marked this pull request as ready for review Apr 17, 2019

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group Apr 17, 2019

@kay0u
Copy link
Member

left a comment

LGTM & Code review

@kay0u

This comment has been minimized.

Copy link
Member

commented May 9, 2019

B蹋坦虣u檀虣毯蹋蛨虨坦m酞蜁蛥p虣酞摊瘫

@JimboJoe
Copy link
Contributor

left a comment

LGTM 馃憤

@JimboJoe

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

Can be merged in 3 days.

Merge pull request #56 from YunoHost-Apps/package_upgrade
Normalization from example_ynh

@maniackcrudelis maniackcrudelis dismissed stale reviews from JimboJoe and kay0u via f9382a4 May 12, 2019

@maniackcrudelis maniackcrudelis requested a review from YunoHost-Apps/apps-group May 12, 2019

@JimboJoe
Copy link
Contributor

left a comment

LGTM 馃憤

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group May 12, 2019

@kay0u

kay0u approved these changes May 13, 2019

@kay0u

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Can be merged in 3 days

@maniackcrudelis maniackcrudelis merged commit f93474c into master May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.