Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #224

Open
wants to merge 8 commits into
base: master
from

Conversation

@JimboJoe
Copy link
Contributor

commented Sep 10, 2019

Problem

  • This application is not up-to-date with version 15 upstream
  • A package upgrade without upstream version update fails (see forum post here
  • There are recurrent error messages about Zend OPcache (see #209)

Solution

  • *Upgrade to latest version 15 (15.0.11) #221 *
  • Change the scope of the exec_occ and create_external_storage function, which are needed even if there is no change of the upstream version #218
  • Remove redundant OPcache enabling parameter #219

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Sep 10, 2019

@kay0u
Copy link
Member

left a comment

LGTM & code review

Merge pull request #218 from YunoHost-Apps/fix_exec_occ_scope
Fix scope of exec_occ and create_external_storage functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.