Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #249

Open
wants to merge 4 commits into
base: master
from
Open

Testing #249

wants to merge 4 commits into from

Conversation

@JimboJoe
Copy link
Contributor

JimboJoe commented Dec 29, 2019

Problem

  • The application is not up-to-date
  • As stated by metalux on the chat room, nextcloud will crash a Raspberry Pi if it needs a lot of ram.
    That's because php will spawn too much process to handle the request.

Solution

  • Upgrade to latest 15.x version 15.0.14
  • Use ynh_get_scalable_phpfpm to adapt php to the actual device.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review : Kay0u
  • Approval (LGTM) : Kay0u
  • Approval (LGTM) : Maniack C
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.
maniack and others added 4 commits Dec 6, 2019
Upgrade to upstream version 15.0.14
 Do not use too much process for php
@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Jan 5, 2020
@JimboJoe

This comment has been minimized.

Copy link
Contributor Author

JimboJoe commented Jan 16, 2020

🆙

@JimboJoe JimboJoe requested a review from YunoHost-Apps/apps-group Jan 19, 2020
@kay0u
kay0u approved these changes Jan 19, 2020
Copy link
Member

kay0u left a comment

LGTM & Code review

@kay0u

This comment has been minimized.

Copy link
Member

kay0u commented Jan 19, 2020

Can be merged in 3 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.