Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #517

Merged
merged 14 commits into from Dec 10, 2022
Merged

Testing #517

merged 14 commits into from Dec 10, 2022

Conversation

ericgaspar
Copy link
Member

@ericgaspar ericgaspar commented Oct 6, 2022

  • upgrade to 25.0.1

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

🚀
Test Badge

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

May the CI gods be with you!
Test Badge

@MCMic
Copy link

MCMic commented Oct 24, 2022

Note that 25 breaks 32bit support in its current state.
Also most applications are not released yet for 25.

@alexAubin
Copy link
Member

Ogod, Nextcloud is indeed dropping support for 32 bit ... This is going to be fun :/

https://help.nextcloud.com/t/32-bit-support-is-no-longer-available-from-nextcloud-what-are-the-takeaways/143879

@lapineige
Copy link
Member

One update went fine… but one other (server) no longer allows me to connect :(

@lapineige
Copy link
Member

Ogod, Nextcloud is indeed dropping support for 32 bit ... This is going to be fun :/

https://help.nextcloud.com/t/32-bit-support-is-no-longer-available-from-nextcloud-what-are-the-takeaways/143879

Could this upgrade be disabled on all 32-bits systems ?

@alexAubin
Copy link
Member

alexAubin commented Oct 29, 2022

Could this upgrade be disabled on all 32-bits systems ?

We can probably check at the beginning of the script if the system is 32 bits and immediately stop the upgrade process, that's pretty easy

What I'm worried about is that "we" (the YunoHost project) probably have quite a lot of users who are running a 32 bit server (eg a RPi 2, or even RPi 3 or 4 if running with the 'old' 32 bit OS) and people ultimately have the choice between

  • "buying a new hardware / reinstalling from scratch" (= super annoying and bad for ecology etc.)
  • OR "keep using Nextcloud 24 for X years before ultimately buying a new hardware / reinstalling from scratch" (= bad for security and still pretty annoying) 😟

@lapineige
Copy link
Member

One update went fine… but one other (server) no longer allows me to connect :(

Ok I think this issue was unrelated and is now gone.

But on that server, Nextcloud, on the /settings/admin/overview page, I have this message:

It seems like you are running a 32-bit PHP version. Nextcloud needs 64-bit to run well. Please upgrade your OS and PHP to 64-bit!

It's a Raspberry Pi 4. Nextcloud is running well as far as I can tell.
What's happening ? 🤔

@lapineige
Copy link
Member

By the way, until Yunohost Nextcloud package provide 24.0.6, this is the only branch that help fix the last disclosed (quite big) security issues : https://www.cert.ssi.gouv.fr/avis/CERTFR-2022-AVI-961/

@alexAubin
Copy link
Member

It seems like you are running a 32-bit PHP version. Nextcloud needs 64-bit to run well. Please upgrade your OS and PHP to 64-bit!

It's a Raspberry Pi 4. Nextcloud is running well as far as I can tell.
What's happening ?

I didn't really digged in to have specific details, I think overall they are just now focusing on the 64-bit use case, and 32 bit installation may work but have lower performances because they're won't be trying to keep it "smooth and optimized" anymore ...

Imho this is mainly a depreciation message considering they'll drop support for it ... which imho should have been made like 1 year ago and not just right before they drop support in version 25 ? x_X

@Sebseb01
Copy link

Hello,

I have upgraded my Nextcloud 22 to 25 (with testing branch) without any dificulty. I have an yunohost in an lxc container on a X86_64 (Bullseye).

Some apps are not ready for 25. But migration process works well.

Thanks

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

🌻
Test Badge

tituspijean
tituspijean previously approved these changes Nov 3, 2022
scripts/install Outdated Show resolved Hide resolved
scripts/upgrade Outdated Show resolved Hide resolved
@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

Alrighty!
Test Badge

@ericgaspar
Copy link
Member Author

!testme

@yunohost-bot
Copy link
Contributor

🚀
Test Badge

@nathanael-h
Copy link
Contributor

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@lapineige
Copy link
Member

Let's merge ?

@lapineige
Copy link
Member

lapineige commented Dec 10, 2022

When trying to upgrade:

Sorry, Nextcloud has deprecated 32-bit support

This has to be announced somewhere, especially for Raspberry Pi owners…

@ericgaspar ericgaspar merged commit 2741a05 into master Dec 10, 2022
@lapineige
Copy link
Member

It seems like you are running a 32-bit PHP version. Nextcloud needs 64-bit to run well. Please upgrade your OS and PHP to 64-bit!

It's a Raspberry Pi 4. Nextcloud is running well as far as I can tell.
What's happening ?

I didn't really digged in to have specific details, I think overall they are just now focusing on the 64-bit use case, and 32 bit installation may work but have lower performances because they're won't be trying to keep it "smooth and optimized" anymore ...

Imho this is mainly a depreciation message considering they'll drop support for it ... which imho should have been made like 1 year ago and not just right before they drop support in version 25 ? x_X

End of support for 32bits in Nextcloud 26: https://help.nextcloud.com/t/deprecation-of-32-bit-support-ends-completely-with-nextcloud-26/150926

@lapineige
Copy link
Member

lapineige commented Dec 10, 2022

So now I understand : 32 bit is still supported, but until this 25.0.2 version there were a bug and it wasn't working: nextcloud/server#34905
https://help.nextcloud.com/t/deprecation-of-32-bit-support-ends-completely-with-nextcloud-26/150926

So let's remove the blocking warning, and just warn people this will be the last version (v25) available and they need to switch to 64 bit, but don't block them ?

@lapineige
Copy link
Member

lapineige commented Dec 10, 2022

PR here: #531
Edit: merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants