Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #66

Open
wants to merge 9 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@kay0u
Copy link
Member

commented May 13, 2019

Problem

  • Missing php-string and php-xml
  • Don't follow example template

Solution

  • Adding missing dependencies
  • Normalize

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

JimboJoe and others added some commits Mar 16, 2019

Merge pull request #65 from YunoHost-Apps/package_upgrade
Normalization from example_ynh
Merge pull request #63 from YunoHost-Apps/fix_add_dependencies
Add missing php-string and php-xml dependencies

@kay0u kay0u requested a review from YunoHost-Apps/apps-group May 13, 2019

@Josue-T

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

Tried this testing version now it fail with this error:

153023 DEBUG ++ echo ''
153024 DEBUG ++ tr '\n' +
153025 DEBUG + local weight_values=26
153026 DEBUG + local max_progression=31
153028 DEBUG + increment_progression=14
153029 DEBUG + previous_weight=2
153030 DEBUG + local scale=20
153032 DEBUG + local progress_string1=####################
153033 DEBUG + local progress_string0=....................
153034 DEBUG + '[' 0 -eq 0 ']'
153035 DEBUG + local effective_progression=9
153036 DEBUG + local progression_bar=#########...........
153038 DEBUG + local print_exec_time=
153039 DEBUG + '[' 0 -eq 1 ']'
153040 DEBUG + ynh_print_info '[#########...........] > Reconfiguring ttrss...'
153042 DEBUG + local legacy_args=m
153043 DEBUG + args_array=([m]=message=)
153052 WARNING ./upgrade: ligne 131: tmpdir : variable sans liaison
153055 DEBUG + declare -Ar args_array
153059 WARNING !!
153062 DEBUG + local message
153064 WARNING   ttrss's script has encountered an error. Its execution was cancelled.
153066 INFO [#########...........] > Reconfiguring ttrss...
153067 DEBUG + ynh_handle_getopts_args '[#########...........] > Reconfiguring ttrss...'
153069 WARNING !!
153070 DEBUG + set +x
153071 WARNING Upgrade failed.
Fix upgrade
Reconfigure ttrss only if there's an upgrade of the upstream app.
@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

We indeed do not test that case with an upgrade of the package only.
$tmpdir was declared only for core upgrade.

But there's actually no reason to reconfigure the app if there's no upgrade of the core.

@Josue-T

This comment has been minimized.

Copy link
Contributor

commented May 13, 2019

We indeed do not test that case with an upgrade of the package only.
$tmpdir was declared only for core upgrade.

But there's actually no reason to reconfigure the app if there's no upgrade of the core.

Work this time, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.