New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string helper if string is empty #115

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
2 participants
@Josue-T
Copy link
Contributor

Josue-T commented Jan 23, 2019

Problem

I saw sometime some bug while some boot try some POST request

DATE HOUR [error] 4844#4844: *39358 lua entry thread aborted: runtime error: /usr/share/ssowat/helpers.lua:41: bad argument #1 to 'sub' (string expected, got nil)
stack traceback:
coroutine 0:
        [C]: in function 'sub'
        /usr/share/ssowat/helpers.lua:41: in function 'starts'
        /usr/share/ssowat/access.lua:165: in function </usr/share/ssowat/access.lua:1>, client: 148.72.232.64, server: domain.tld, request: "POST /yunohost/sso/?r=AWFf8fal3FAwfd3ASF3f9afafaFA=/xmlrpc.php HTTP/1.1", host: "domain.tld"

Solution

Return false if the helper get a null string as input.

PR status

Not tested because I don't know how to reproduce the bug.

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Feb 21, 2019

Tested in interactive lua and it works ! Thanks !

@alexAubin alexAubin added this to the 3.5.x milestone Feb 21, 2019

@alexAubin alexAubin merged commit 5bd4de4 into stretch-unstable Feb 21, 2019

@alexAubin alexAubin deleted the fix_string_helper branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment