Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix ynhpanel.js access in unprotected case #119
Conversation
Josue-T
requested review from
Psycojoker
,
zamentur
and
alexAubin
Feb 7, 2019
This comment has been minimized.
This comment has been minimized.
Wow that looks quite technical and must have been painful to debug x_x Thanks a lot for this, I'll have a look at some point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Josue-T commentedFeb 7, 2019
Problem
To reproduce this bug you need this :
a.tld
(as the main yunohost domain)b.tld
b.tld
wich use the "unprotected_uri" and which show the "Yunohost tile".a.tld
.b.tld/
.This happen because SSOwat don't detect any cookies for
b.tld
, so it considere the client as not authenticated.Solution
Force SSOwat to reauthenticate the user for
b.tld
by a redirection. Note that process already work when the app is not installed in the root of the domain.