New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ynhpanel.js access in unprotected case #119

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

Projects
None yet
2 participants
@Josue-T
Copy link
Contributor

Josue-T commented Feb 7, 2019

Problem

To reproduce this bug you need this :

  • Have to independant domain : by example :
    • a.tld (as the main yunohost domain)
    • b.tld
  • Install an app on the "root" of b.tld wich use the "unprotected_uri" and which show the "Yunohost tile".
  • Logon in sso on a.tld.
  • Go on the app which is in b.tld/.
  • See that you don't see the "Yunohost tile".

This happen because SSOwat don't detect any cookies for b.tld, so it considere the client as not authenticated.

Solution

Force SSOwat to reauthenticate the user for b.tld by a redirection. Note that process already work when the app is not installed in the root of the domain.

@Josue-T Josue-T requested review from Psycojoker , zamentur and alexAubin Feb 7, 2019

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Feb 7, 2019

Wow that looks quite technical and must have been painful to debug x_x

Thanks a lot for this, I'll have a look at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment