Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for userinfo json #133

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@zamentur
Copy link
Contributor

commented Mar 22, 2019

The problem

Before there was ynhpanel.json we could use to get info about apps the user can use. It could be useful to display this kind of info on a page, like menu_ynh or other things like that.

The solution

Restore this feature, but rename the file to explain better the goal of this file.

Status

Untested

How to test

Validation

  • Principle agreement 0/2 :
  • Quick review 0/1 :
  • Simple test 0/1 :
  • Deep review 0/1 :

@zamentur zamentur changed the base branch from stretch-unstable to theming-reloaded Mar 22, 2019

@zamentur zamentur referenced this pull request Mar 22, 2019
0 of 4 tasks complete
@@ -0,0 +1 @@
{}

This comment has been minimized.

Copy link
@alexAubin

alexAubin Mar 22, 2019

Member

I still don't understand why we need this empty file :/ Can't we just return an empty dict when needed with creating this file x_x (I'm not even sure to understand how/if that file is actually likely to be used somewhere)

@@ -334,6 +334,7 @@ end

if hlp.is_logged_in() then
-- serve ynhpanel files
serveAsset("/ynh_userinfo.json", "js/ynh_userinfo.js")

This comment has been minimized.

Copy link
@alexAubin

alexAubin Mar 25, 2019

Member

This doesn't work ... Accessing domain.tld/ynh_userinfo.json doesn't return the expected info... Also this function serveAsset will then apply public-caching ... but since this json is meant to contain private info, this should probably be cached as private instead

@alexAubin alexAubin changed the base branch from theming-reloaded to stretch-unstable Apr 1, 2019

@alexAubin alexAubin changed the title Theming reloaded userinfo Support for userinfo json Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.