Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new theme Unsplash forek from "Clouds" #139

Open
wants to merge 4 commits into
base: stretch-unstable
from

Conversation

@moutonjr
Copy link

commented Jul 9, 2019

Background change over each photos
Selection of "Nature" performed on Unsplash API
Kept white font for SSO main element

Tested on Stretch & Jessie (but no reason that other wouldn't work server-side, Firefox latest and Chrome client-side. Responsive.
Remaining problems: photos color may lead to unreadable labels. FIX ME!
Capture
Responsive

Geoff Montel
Adding new theme Unsplash forek from "Clouds"
Background change over each photos
Selection of "Nature" performed on Unsplash API
Kept white font for SSO main element
Remaining problems: photos color may lead to unreadable labels. Fix me!
@Psycojoker

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Remaining problems: photos color may lead to unreadable labels. FIX ME!

Generally adding a text-shadow helps quite a lot for those situations, event a discrete one.

Geoff Montel
Adding shadowing for white images.
Thanks to Psycojoker comment.
Tested Responsive + Chrome latest & Firefox
@moutonjr

This comment has been minimized.

Copy link
Author

commented Jul 9, 2019

Great idea, this is definitely better.
Capture2

@Psycojoker

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

LGTM now, I guess it need testing or yolo merging :)

Thx again <3

@kay0u

This comment has been minimized.

Copy link

commented on portal/assets/themes/unsplash/custom_portal.css in 3a3d0e9 Jul 11, 2019

Why did you add and remove your warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.