Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: bug serving files because of LUA exception #141

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@moutonjr
Copy link

commented Jul 14, 2019

"Interrupted system call" during PWDIR change on "popen" function
Restored by removing FIND's wildcard which could yield fo emptiness
(example : mydir/ is empty; making cd mydir && find * yielding
to non argumented FIND function.

Tested on Stretch with nginx (1.10.3-1+deb9u2) and lua5.1 (5.1.5-8.1+b2).

Note that this could lead to bugs, code refactor should enclose lua-filesystem (1.6.3-1),
but I'm a rookie in LUA.

Geoff Montel
Fixed: bug serving files because of LUA exception
"Interrupted system call" during PWDIR change on "popen" function
Restored by removing FIND's wildcard which could yield fo emptiness
(example : `mydir/` is empty; making `cd mydir && find *` yielding
to non argumented FIND function.

Tested on Stretch with nginx (1.10.3-1+deb9u2) and lua5.1 (5.1.5-8.1+b2).

Note that this could lead to bugs, code refactor should enclose lua-filesystem (1.6.3-1),
but I'm a rookie in LUA.
@moutonjr

This comment has been minimized.

Copy link
Author

commented Jul 14, 2019

(note that this crashed some of my apps behind SSOWat, e.g. rainloop, yeilding to HTTP/500 on loadings)

@decentral1se
Copy link

left a comment

Looks legit then if I understood correctly!

➜  ~ mkdir test 
➜  ~ cd test && find * -type f
zsh: no matches found: *
[1]    8291 exit 1     find * -type f
➜  test echo $?
1
➜  test cd ..                    
➜  ~ find test -type f        
➜  ~ echo $?
0
@alexAubin

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

Oh I didn't saw that PR earlier

That's an interesting fix, thank you 😲 !

@alexAubin
Copy link
Member

left a comment

Not tested but LGTM

@alexAubin alexAubin added this to the 3.7.x milestone Aug 5, 2019

@alexAubin alexAubin merged commit 07e8a29 into YunoHost:stretch-unstable Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.