New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for featured and high quality apps #677

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Feb 1, 2019

Replace #655 with a tag in the community list instead of a new list.
Related to YunoHost/yunohost-admin#225 to manage the tag in the app list.

For all who'd worried that I really modify python code. Don't worry, I wasn't alone to do it.

The discussion about this feature is here. Nothing has been decided yet, still I go forward to propose some concrete work.
I especially would like to have the point of view of the @YunoHost/apps group, since we would be concerned as we would have to give a quick review to each PR on those apps.


EDIT

During our last meeting it was decided:

  • In a mid-long term, get rid of Official and Community list, and merge into one unique list.
    Let's say simply "One list to rule them all, One list to find them; One list to bring them all and [...]." Don't remember the end of this sentence... Never mind...
  • Add a status of the maintained state of an app. Like the way Debian do it. ‘Orphaned’, ‘Request for Adoption’, ‘Request For Help’.
  • Keep 'Featured apps' as apps highlighted for editorial reasons. Maybe via a poll on the forum, not defined yet.
  • Adapt level 8 for high quality apps. Validated by Apps group.
  • Modify level 4, to not block apps anymore under level 3 because of ldap or SSO.

Related PR:
Those PR should be merged in that order to not break anything.

  • This very PR should be merged first.
  • Add High Quality tag for some apps #678
  • Modify levels 4, 6 and 8 #52
  • Update packaging_apps_levels.md #927
  • Add support for featured community apps #225
  • Merge Official and Community into Apps #694
  • Get apps from apps.json instead of community and official #13

TODO list:

  • Add a filter for High Quality apps in to yunohost admin app list
  • Add support for maintained states in yunohost-admin
  • Update readme to explain how to use maintained states
  • Update package_check to read the value of high_quality into the app list.
  • Create a new list for all apps.
  • Handle that list with list_builder.
  • Update CI to handle that new list.
  • Update the documentation.
  • Use automatically that list, instead of the Official one.
  • Add a migration to remove the Official list an use the new one instead.
  • Merge all that mess.
  • Enjoy \o/

This PR is still waiting for a global acceptance from the @YunoHost/apps group.

@anmol26s

This comment has been minimized.

Copy link
Contributor

anmol26s commented Feb 5, 2019

I am ok with it.

@maniackcrudelis maniackcrudelis changed the title Add support for featured apps Add support for featured and high quality apps Feb 20, 2019

@kay0u

This comment has been minimized.

Copy link
Contributor

kay0u commented on README.md in 143799e Feb 20, 2019

You mean a Featured app?

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

maniackcrudelis commented Feb 20, 2019

The idea is to have both High Quality apps (the name could be changed, I don't care...) AND Featured apps.

Show resolved Hide resolved README.md Outdated

maniackcrudelis added some commits Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment