Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] ensure that all apps in lists is ok #695

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

@kay0u
Copy link
Member

@kay0u kay0u commented Feb 21, 2019

This script check the url, the branch an the revision for all apps in lists.

@maniackcrudelis
Copy link
Contributor

@maniackcrudelis maniackcrudelis commented Apr 2, 2019

@alexAubin @Psycojoker do you have any opinion on that ?

Loading

Copy link
Member

@alexAubin alexAubin left a comment

Not tested but LGTM

Loading

tests/testsRepo.py Outdated Show resolved Hide resolved
Loading
Copy link
Member

@alexAubin alexAubin left a comment

Hmmm in fact I'm wondering how much of a good idea it is to run ~200 git clones in Travis ...

Github ain't gonna like that ... at least not without a token ... but even with a token it probably takes hell of a time :/

I dunno if there could be some trick in travis to only check apps affected by the commits ?

Loading

@kay0u
Copy link
Member Author

@kay0u kay0u commented Apr 2, 2019

Hmmm in fact I'm wondering how much of a good idea it is to run ~200 git clones in Travis ...

Github ain't gonna like that ... at least not without a token ... but even with a token it probably takes hell of a time :/

I dunno if there could be some trick in travis to only check apps affected by the commits ?

I can get modified lines in the PR (like a diff between the PR and master), retrieve the json part we want to check, and check it? It will be ugly but I can do it :-)

Loading

@alexAubin
Copy link
Member

@alexAubin alexAubin commented Apr 2, 2019

I can get modified lines in the PR (like a diff between the PR and master), retrieve the json part we want to check, and check it? It will be ugly but I can do it :-)

Well yup, not sure if we can build a reliable way but anyway I doubt that we really want to trigger 250+ git clones each time we do a PR / commit here :P

Loading

@alexAubin
Copy link
Member

@alexAubin alexAubin commented Apr 4, 2020

What the hell, this is from more than 1 year ago !? I was convinced this was for less than 6 months ago x_x

Anyway, @kay0u : I know we love travis but what would you think about having our own cache of all the git clones (with --shallow-commit-whatever), and running the tests on our infra every day or X hours ? Not only is this less crazy in terms of having hundreds of git clone every commit (or weird engineering to test only the diff) but we could also :

Loading

@kay0u
Copy link
Member Author

@kay0u kay0u commented Apr 4, 2020

Meh 1 year already :/

I guess the list builder will fail if the sha1 is not valid for the repo? It might be enough.

use it for analysis of helper usage or related stuff (had to do that kind of stuff a lot when working on helpers / package check) ...

The app CI is here for that right?

Loading

@alexAubin
Copy link
Member

@alexAubin alexAubin commented Apr 4, 2020

The app CI is here for that right?

I was meaning thing like "finding out how many apps use helper X", or anything that involves to "grep -r" all apps repo ... or more recently running a new package_linter on all repo to find about all nginx path traversal issue, etc ...

Github sort of allow searches, but it's pretty limited

Anyway, I'm working on a rework of the list builder based on this idea right now ..

Loading

@jedie
Copy link
Contributor

@jedie jedie commented Apr 24, 2021

BTW. Travis is going to close support for opensouce projects, isn't it?!?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants