Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] ensure that all apps in lists is ok #695

Open
wants to merge 2 commits into
base: master
from

Conversation

@kay0u
Copy link
Contributor

commented Feb 21, 2019

This script check the url, the branch an the revision for all apps in lists.

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Apr 2, 2019

@alexAubin @Psycojoker do you have any opinion on that ?

@alexAubin
Copy link
Member

left a comment

Not tested but LGTM

tests/testsRepo.py Outdated Show resolved Hide resolved
@alexAubin
Copy link
Member

left a comment

Hmmm in fact I'm wondering how much of a good idea it is to run ~200 git clones in Travis ...

Github ain't gonna like that ... at least not without a token ... but even with a token it probably takes hell of a time :/

I dunno if there could be some trick in travis to only check apps affected by the commits ?

@kay0u

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

Hmmm in fact I'm wondering how much of a good idea it is to run ~200 git clones in Travis ...

Github ain't gonna like that ... at least not without a token ... but even with a token it probably takes hell of a time :/

I dunno if there could be some trick in travis to only check apps affected by the commits ?

I can get modified lines in the PR (like a diff between the PR and master), retrieve the json part we want to check, and check it? It will be ugly but I can do it :-)

@alexAubin

This comment has been minimized.

Copy link
Member

commented Apr 2, 2019

I can get modified lines in the PR (like a diff between the PR and master), retrieve the json part we want to check, and check it? It will be ugly but I can do it :-)

Well yup, not sure if we can build a reliable way but anyway I doubt that we really want to trigger 250+ git clones each time we do a PR / commit here :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.