Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All these apps are not "working", shouldn't have a level > 0 #809

Merged
merged 3 commits into from Aug 18, 2019

Conversation

@alexAubin
Copy link
Member

commented Aug 1, 2019

No description provided.

@kay0u

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

🤔 Uuh, a non working app shouldn't have any "level" if I remember well.

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Yea, we can also remove those entirely ¯\_(ツ)_/¯

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

Those levels were set before those app were put as not working (or in progress for some by the way)
Is it really a problem to have those ?

@alexAubin

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

Not really since most codes reading this file will / should assume level to be 0 (or None) if the app ain't working. Still, I wouldn't be surprised that some users read this raw file and think that "oh this app is notworking but still is level 3 so maybe I can install it"

@kay0u

kay0u approved these changes Aug 1, 2019

kay0u and others added some commits Aug 5, 2019

@alexAubin alexAubin merged commit dc55c9b into master Aug 18, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@alexAubin alexAubin deleted the level-0-for-not-working-apps branch Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.