Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smartypants extension to enhance typography #1717

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tituspijean
Copy link
Contributor

@tituspijean tituspijean commented Jul 11, 2021

cf. #1716

Adding smartypants extension beautifies and respects typography laws by using the curved apostrophes and quotation marks, and even offers to display French guillemets. Documentation has been updated accordingly.

@zamentur
Copy link
Member

I don't see how it doesn't apply to other content than fr ?

@tituspijean
Copy link
Contributor Author

tituspijean commented Jul 12, 2021

It indeed does not discriminate between languages for now. However, per Wikipedia, both apostrophes and quotation marks in English can be used with their curved, typographic version.

This PR does not specifically target French, even though the issue arose from the French translation. From the second link, I see we may have issues with the German version (inverted location). I could have a look into it, could be a simple if to apply somewhere in the code.

@Psycojoker
Copy link
Member

idk if this correctly take care of avoiding reformating code snippets like in <pre> of <codeblock> tag, otherwise that could break a lot of command line that people cold copy paste (already experienced that)

tbh I find people forcing for The Right French Typography so annoying that I don't want to hear about it anymore but that's not a real argument.

@tituspijean
Copy link
Contributor Author

idk if this correctly take care of avoiding reformating code snippets like in <pre> or <codeblock> tag, otherwise that could break a lot of command line that people cold copy paste (already experienced that)

You can check it out on my test server (ynh.pijean.ovh/fr/packaging_apps_arguments_format). Code blocks are excluded (as stated in the doc of the extension).

tbh I find people forcing for The Right French Typography so annoying that I don't want to hear about it anymore but that's not a real argument.

I hear you. I am merely proposing a lazy way of handling it, while maintaining our habits of using ' and ".

@tituspijean
Copy link
Contributor Author

The plugin clashes with the Shortcode-UI tabs extension. Do not merge.

@tituspijean tituspijean marked this pull request as draft September 4, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants