New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup workaround #899

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Gofannon
Copy link
Contributor

Gofannon commented Jan 13, 2019

Add a workaround for people to get an access to their backups with the admin user

Should be fixed in the core. See commit details

Gofannon added some commits Jan 13, 2019

[enh] linter 'markdown'
Can cause issue with titles size on the final documentation

"From the webadmin" will move from <h4> to <h3> and will be shwoned bigger
[fix] add workaround to manage backup
Needed while waiting for a solution. See YunoHost/issues#1266
@Gofannon

This comment has been minimized.

Copy link
Contributor Author

Gofannon commented Jan 13, 2019

I can translate in French too if the PR is fine for merging and/or accepted

Show resolved Hide resolved backup.md
@Gofannon

This comment has been minimized.

Copy link
Contributor Author

Gofannon commented Jan 14, 2019

Is it possible to merge the linter part before closing the PR? 1a2c31f

Or shall I do another PR ?

@alexAubin

This comment has been minimized.

Copy link
Member

alexAubin commented Jan 23, 2019

I think we can just force-push the branch to remove 1f085dc ?

About 1a2c31f, if it's easily-doable, can you also propagate the same change on the french version ? (Did you use some sort of automatic tool for this, since I see you mention a 'linter' ?)

@Gofannon

This comment has been minimized.

Copy link
Contributor Author

Gofannon commented Jan 23, 2019

I think we can just force-push the branch to remove 1f085dc ?

Yes

About 1a2c31f, if it's easily-doable, can you also propagate the same change on the french version ? (Did you use some sort of automatic tool for this, since I see you mention a 'linter' ?)

I can modify the french version too. i can do a new PR to bundle the new versions too if it's easier.

I used an addon and did the modification by hand : https://github.com/DavidAnson/vscode-markdownlint
There are rules similar to YEP https://yunohost.org/#/packaging_apps_guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment