Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging_apps_levels.md #927

Merged
merged 3 commits into from Mar 22, 2019

Conversation

Projects
None yet
5 participants
@maniackcrudelis
Copy link
Contributor

commented Feb 20, 2019

According to our discussion during the last meeting.
We would like to use the level 8 for high quality packages.

So I made a little refactoring of the levels. Also I change the level 4, which is quite complicated to handle and not really representative of the real level of an app.

To explain my modifications:

  • The level 4 is now about how the app handles backup and restore. It's a must have now.
  • While the level 6 is, for the automatic part with Package_check, is only about the app being in YunoHost-Apps.
    Not that much, but didn't find anything else we could check automatically without changing all levels.
    And anyway, nowadays, we're much about very low level (1-3) and level 7.
  • Level 7 gets many YEP that were in level 8 and 9, but actually already expected for a level 7 app.
  • Level 8 gets ldap and SSO. Since we can't check that automatically.
  • Level 9 gets app isolation. We don't know yet how to do that properly for most of our apps

The level 8 would be now a manual level (Accorded only by Apps group) about high quality apps that respect all packaging recommendations.

Related to YunoHost/apps#677

This PR should be merged after #935

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Feb 20, 2019

- [YEP 2.18.5](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-2185---ajouter-la-tuile-yunohost-pour-naviguer-facilement-entre-les-applications----valid%C3%A9--manuel--official-) : Add the YunoHost tile to easily navigate between applications
- [YEP 3.4](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-34---isoler-lapp----brouillon--manuel--official-) : Isolate app
- [YEP 4.1](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-41---lier-au-ldap----valid%C3%A9--manuel--official-) : Link to ldap
- [YEP 4.2](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-42---lier-lauthentification-au-sso----valid%C3%A9--manuel--official-) : Bind authentication to sso

This comment has been minimized.

Copy link
@Josue-T

Josue-T Feb 20, 2019

Contributor

I don't think that all actual apps at the (actual) level 7 does both (SSO + LDAP integration). So So maybe it could be good do define more that.

By example I think about discourse or friendica which support only LDAP but not the SSO, So what does we do about that ?

This comment has been minimized.

Copy link
@maniackcrudelis

maniackcrudelis Feb 20, 2019

Author Contributor

What do you mean ?
If an upstream app does support SSO and LDAP but not the package, then that's a problem that should be fixed.

This comment has been minimized.

Copy link
@zamentur

zamentur Feb 26, 2019

Contributor

I was thinking SSO/LDAP to be in level 7. For me, some app with SSO/LDAP could not be High Quality App.

This comment has been minimized.

Copy link
@maniackcrudelis

maniackcrudelis Feb 26, 2019

Author Contributor

But we can't check sso/ldap automatically. That's why I moved those YEP to the level 8.

- [YEP 2.14](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-214---remplir-correctement-un-fichier-de-conf----brouillon--manuel--official-) : Fill a conf file correctly
- [YEP 2.17](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-217---prendre-en-compte-la-version-dorigine-lors-des-mises-%C3%A0-jour----valid%C3%A9--manuel--official-) : Take into account the original version during updates
- [YEP 3.4](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-34---isoler-lapp----brouillon--manuel--official-) : Isolate app

This comment has been minimized.

Copy link
@Josue-T

Josue-T Feb 20, 2019

Contributor

Maybe fore that we can say that need to run as a specific system user. I know that it's not really "Isolation" but it's more easily possible.

Or by example for python apps we can say that we want that the app is installed in a virtual environment.

It just still some proposition to be more clear about that...

This comment has been minimized.

Copy link
@maniackcrudelis

maniackcrudelis Feb 20, 2019

Author Contributor

That's not really isolation indeed.
php provide a way to really isolate apps, but that too effective.

Anyway, I put that on level 9, because we don't have any real solution for the moment.

This comment has been minimized.

Copy link
@zamentur

zamentur Feb 26, 2019

Contributor

+1

Show resolved Hide resolved packaging_apps_levels.md
@@ -175,32 +167,13 @@ If an application is not available on an architecture, and it is impossible to c

YEP to be respected to reach level 9:

- [YEP 2.10](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-210---configurer-les-logs-de-lapplication----brouillon--manuel--working-) : Configure application logs
- [YEP 2.11](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-211---utiliser-une-variable-plut%C3%B4t-que-lapp-id-directement---valid%C3%A9--manuel--official-) : Use a variable rather than the app id directly
- [YEP 2.13](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-213---traduire-le-package-en-anglais----brouillon--manuel--official-) : Translate the package into English
- [YEP 2.14](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-214---remplir-correctement-un-fichier-de-conf----brouillon--manuel--official-) : Fill a conf file correctly
- [YEP 2.17](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-217---prendre-en-compte-la-version-dorigine-lors-des-mises-%C3%A0-jour----valid%C3%A9--manuel--official-) : Take into account the original version during updates

This comment has been minimized.

Copy link
@zamentur

zamentur Feb 26, 2019

Contributor

This YEP should be into level 3 no ?

This comment has been minimized.

Copy link
@maniackcrudelis

maniackcrudelis Feb 26, 2019

Author Contributor

For me, but maybe I misunderstood this YEP, it's more about apps like nextcloud that needs to be careful about which version it has and which it will reach.
For many apps, most of them even, we just don't care to know from which version and to which we're going to update.

- [YEP 2.14](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-214---remplir-correctement-un-fichier-de-conf----brouillon--manuel--official-) : Fill a conf file correctly
- [YEP 2.17](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-217---prendre-en-compte-la-version-dorigine-lors-des-mises-%C3%A0-jour----valid%C3%A9--manuel--official-) : Take into account the original version during updates
- [YEP 3.4](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-34---isoler-lapp----brouillon--manuel--official-) : Isolate app

This comment has been minimized.

Copy link
@zamentur

zamentur Feb 26, 2019

Contributor

+1

- [YEP 2.18.5](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-2185---ajouter-la-tuile-yunohost-pour-naviguer-facilement-entre-les-applications----valid%C3%A9--manuel--official-) : Add the YunoHost tile to easily navigate between applications
- [YEP 3.4](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-34---isoler-lapp----brouillon--manuel--official-) : Isolate app
- [YEP 4.1](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-41---lier-au-ldap----valid%C3%A9--manuel--official-) : Link to ldap
- [YEP 4.2](https://github.com/YunoHost/doc/blob/master/packaging_apps_guidelines_fr.md#yep-42---lier-lauthentification-au-sso----valid%C3%A9--manuel--official-) : Bind authentication to sso

This comment has been minimized.

Copy link
@zamentur

zamentur Feb 26, 2019

Contributor

I was thinking SSO/LDAP to be in level 7. For me, some app with SSO/LDAP could not be High Quality App.

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 12, 2019

#935 got merged.

This PR is the next in the list.

@YunoHost/apps

@kay0u

kay0u approved these changes Mar 12, 2019

@alexAubin
Copy link
Member

left a comment

To me that looks okay though I didn't think deeply about all those ;P

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

No news for more than 20 days.
If no one express a disagreement, I will merge in 3 days.

@maniackcrudelis maniackcrudelis merged commit a0a0e6e into master Mar 22, 2019

@maniackcrudelis maniackcrudelis deleted the modify_app_levels branch Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.