New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ini file for php #52

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
4 participants
@maniackcrudelis
Copy link
Contributor

maniackcrudelis commented Oct 1, 2018

Problem

Solution

  • Get rid of the ini file and merge its content into the pool file.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation


Minor decision

  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@maniackcrudelis maniackcrudelis requested a review from YunoHost/apps Oct 1, 2018

@Josue-T

Josue-T approved these changes Oct 2, 2018

@zamentur
Copy link
Contributor

zamentur left a comment

LGTM

@maniackcrudelis maniackcrudelis merged commit e252637 into master Jan 13, 2019

@maniackcrudelis maniackcrudelis deleted the remove_php_ini branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment