Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup before changing url. #96

Open
wants to merge 1 commit into
base: master
from

Conversation

@maniackcrudelis
Copy link
Contributor

commented Jun 19, 2019

Problem

  • If a changeurl script fails, the app will end in a none fully moved state. Forcing the user to fix it by himself.

Solution

  • Use ynh_backup_before_upgrade into the changeurl script.
  • Remove the nginx config file for the new domain, the remove script will try to remove the old one, as the modification of the config would have happened at the end.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

@maniackcrudelis maniackcrudelis requested a review from YunoHost/apps Jun 19, 2019

@kay0u

kay0u approved these changes Jun 19, 2019

Copy link
Contributor

left a comment

LGTM

@kay0u

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

What do you think about change the name of ynh_backup_before_upgrade in ynh_backup_before? It could be used with actions and config that will become official one day \o/

(We can add an option --action=upgrade to separate backups if needed)

And change ynh_restore_upgradebackup to ynh_restore_backup accordingly

@maniackcrudelis

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

That would mean change it in every scripts as well, is it really worth it?

@kay0u

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

I don't know, maybe not. The naming triggered me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.