Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove postinstall and instead print a text explaining what to do and pointing to the documentation #54

Merged
merged 3 commits into from Dec 18, 2018

Conversation

alexAubin
Copy link
Member

@alexAubin alexAubin commented Nov 29, 2018

This proposes to remove the postinstall being proposed / triggered at the end of the install script.
Motivations behind this is :

  • simplify the command line. Currently we have to run bash <(wget the_url) instead of bash the_url | curl because bash needs access to stdin only for the postinstall that might be run ;
  • imho there's little gain in triggering this from the install script rather than asking the user to do it from the web admin or the cli (so that the admin discovers one or the other rather than the install script masking it ?) ;
  • if the postinstall fails during the install script, it's not easy to debug :|, c.f. Not information on failed post-install while using install.yunohost.org issues#1166
  • we should point at the documentation more often and that's a good occasion to do so ?

install_yunohost Outdated Show resolved Hide resolved
Copy link
Member

@zamentur zamentur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants