New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Unapropriate warning #173

Merged
merged 2 commits into from Oct 27, 2018

Conversation

Projects
None yet
3 participants
@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 9, 2018

So if I understand correctly, the warning about whoami only happens/happened for commands which did not require the authentication, thus the variable was None ?

Not sure why this didn't happen before stretch tho o.O

@Psycojoker

This comment has been minimized.

Member

Psycojoker commented Oct 9, 2018

Not sure why this didn't happen before stretch tho o.O

Looks like it's when I've added warning message everywhere because the previous code strategy was to hide all error messages.

@alexAubin alexAubin added this to the 3.3.x milestone Oct 24, 2018

@alexAubin

This comment has been minimized.

Member

alexAubin commented Oct 24, 2018

Sooo, idk, merging soonish ?

@alexAubin alexAubin self-assigned this Oct 24, 2018

Use 'is None'
Co-Authored-By: alexAubin <alex.aubin@mailoo.org>

@alexAubin alexAubin merged commit 9f7ee73 into stretch-unstable Oct 27, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@alexAubin alexAubin deleted the fix-bad-warning branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment