New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possiblity to get attribute name of conflict in LDAP #181

Merged
merged 3 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@Josue-T
Copy link
Contributor

Josue-T commented Nov 26, 2018

Problem

  • When we call the function validate_uniqueness we can't know if there are a conflict we don't know which attribute have generate a conflict and with which object we have a conflict.
  • We can't manage the error with the function which call validate_uniqueness. Result is that if there are a conflict the user just see a message "Attribute '{attribute}' already exists with value '{value}'" but the user might not know the meaning of the attribute name.

Solution

  • Create a function get_conflict which just return the name of the attribute and it value if there are a conflict.

@Josue-T Josue-T requested review from Psycojoker , alexAubin , JimboJoe and zamentur Nov 26, 2018

@Josue-T Josue-T force-pushed the LDAP_validate_uniqueness branch from 687445c to 893753a Nov 26, 2018

@Josue-T Josue-T force-pushed the LDAP_validate_uniqueness branch from 893753a to b64e2d7 Nov 26, 2018

Show resolved Hide resolved moulinette/authenticators/ldap.py
Show resolved Hide resolved moulinette/authenticators/ldap.py Outdated
Show resolved Hide resolved moulinette/authenticators/ldap.py

@Josue-T Josue-T referenced this pull request Nov 29, 2018

Open

Group permission #585

5 of 14 tasks complete
@alexAubin
Copy link
Member

alexAubin left a comment

Sounds good to me 👍

@alexAubin alexAubin added this to the 3.4.x milestone Dec 10, 2018

@alexAubin alexAubin merged commit 9a8b5c0 into stretch-unstable Dec 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the LDAP_validate_uniqueness branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment