New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] Display date as system timezone #184

Merged
merged 3 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@zamentur
Copy link
Contributor

zamentur commented Dec 9, 2018

The problem

Dates are not well displayed. Currently it's just a str(date) and in some case yunohost give a timestamp... We need to harmonize that, and manage timezone.

Solution

Display dates using system timezone if we use cli.

Note: With the api, the json encoder already use iso format on the date object, so if the date is not "naive" date the representation generated by the api contains timezone info.
https://github.com/YunoHost/moulinette/blob/stretch-unstable/moulinette/utils/serialize.py#L30

Status

Ready
This PR is linked to
YunoHost/yunohost#552

@zamentur

This comment has been minimized.

Copy link
Contributor Author

zamentur commented Dec 10, 2018

Ready and tested

@alexAubin
Copy link
Member

alexAubin left a comment

Tested a few things, LGTM

@alexAubin alexAubin added this to the 3.4.x milestone Dec 10, 2018

@alexAubin alexAubin merged commit 6411e5a into stretch-unstable Dec 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@alexAubin alexAubin deleted the enh-human-readable-date branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment