Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staticmethod and format_arg_names fix #234

Open
wants to merge 1 commit into
base: stretch-unstable
from

Conversation

@kay0u
Copy link
Member

kay0u commented Jan 14, 2020

  • staticmethod was not really static
  • use startswith in format_arg_names
@@ -156,7 +154,8 @@ def parse_args(self, args, **kwargs):

# Arguments helpers

def prepare_action_namespace(self, tid, namespace=None):
@staticmethod

This comment has been minimized.

Copy link
@Psycojoker

Psycojoker Jan 17, 2020

Member

Why have you made this method static? It's because "self" isn't used inside?

This comment has been minimized.

Copy link
@kay0u

kay0u Jan 17, 2020

Author Member

Uuh yes, is it bad?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.