Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests and linter not already fixed by #227 #236

Open
wants to merge 2 commits into
base: stretch-unstable
from

Conversation

@autra
Copy link

autra commented Feb 9, 2020

Together with #227, this should make the build green.

The root cause of the last failing tests the fact moulinette is writing its lockfiles in /var/run. However, at least on Ubuntu, only root can do that.

This PR fixes that by allowing to configure the runtime dir of moulinette. I chose to add an env variable for this purpose, as it seems more appropriate than in the yml file.

To make things complete, I also added a commit that fixes the linter.

autra added 2 commits Feb 9, 2020
Before this commit, moulinette was using lockfiles in /var/run. However
this prevents it to run as non-root user. To allow this and to
facilitate unit testing (typically run as regular user), this commit
adds a MOULINETTE_RUN_DIR env variable.
@autra

This comment has been minimized.

Copy link
Author

autra commented Feb 9, 2020

I just noticed this PR is more or less contained in #230 :-D My solution to the lockfile problem is a bit different though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.