New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about the use of add_header in nginx conf #45

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
2 participants
@alexAubin
Copy link
Member

alexAubin commented Feb 9, 2019

c.f. https://www.peterbe.com/plog/be-very-careful-with-your-add_header-in-nginx and YunoHost-Apps/nextcloud_ynh#160

Apps should not use add_header in nginx conf, but rather more_set_headers ...

This adds a warning in package_linter.

@alexAubin alexAubin referenced this pull request Feb 9, 2019

Merged

Upgrade to upstream version 15.0.4 #160

2 of 8 tasks complete
@alexAubin

This comment has been minimized.

Copy link
Member Author

alexAubin commented Feb 10, 2019

(Planning to merge this in ~3 days)

@alexAubin alexAubin merged commit f8bbccd into master Feb 13, 2019

@alexAubin alexAubin deleted the warn_about_add_header branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment