Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
[enh] Add PCRE regex support #102
As the original branch of this #44 is missing, I have create a new one.
Lua pattern are not well known and a lot of packager don't know how write this kind of regex. PCRE seems more familiar.
Add support of PCRE, and keep support of lua pattern during a transition period.
Tested with nextcloud
How to test
./ynh-dev use-git ssowat
@maniackcrudelis said on the chat that this was a good idea too and that it has already been discussed in the past apparently.
I'm personally a bit weirded out by this dual match approach, I hope this won't create weird bugs :/ Maybe we should have something like explicitely specifying the regex type? Like starting the regex string with "pcre:" and "luare:" (default)?
Would there be a "simple" way to detect if the user is using Lua regexed or PCRE regexes ? So far it essentially looks like this will support both - but if we really want to push the usage to PCRE, we shall warn packagers about Lua regexes being deprecated somehow ?
This doesn't prevent from merging this though (I would be happy to merge this right away and include this in 3.3 testing)